darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

PART 1: Created and implemented enums throughout the codebase to replace hardcoded status strings, improving type safety and reducing the risk of typos.

Browse Source
This commit is contained in:
Beverly Nguyen
2025-07-04 16:37:04 -07:00
parent db20c888f2
commit b73b4ac73e
12 changed files with 132 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/status/views/healthcheck.py
View File

@@ -5,6 +5,7 @@ from flask import current_app, jsonify, request
from redis import RedisError
from app import status_api_client, version
from app.enums import HealthStatus
from app.extensions import redis_client
from app.status import status
from notifications_python_client.errors import HTTPError
@@ -13,16 +14,16 @@ from notifications_python_client.errors import HTTPError
@status.route("/_status", methods=["GET"])
def show_status():
if request.args.get("elb", None) or request.args.get("simple", None):
return jsonify(status="ok"), 200
return jsonify(status=HealthStatus.OK.value), 200
else:
try:
api_status = status_api_client.get_status()
except HTTPError as err:
current_app.logger.exception("API failed to respond")
return jsonify(status="error", message=str(err.message)), 500
return jsonify(status=HealthStatus.ERROR.value, message=str(err.message)), 500
return (
jsonify(
status="ok",
status=HealthStatus.OK.value,
api=api_status,
git_commit=version.__git_commit__,
build_time=version.__time__,
@@ -60,10 +61,10 @@ def show_redis_status():
)
except HTTPError as err:
current_app.logger.exception("API failed to respond")
return jsonify(status="error", message=str(err.message)), 500
return jsonify(status=HealthStatus.ERROR.value, message=str(err.message)), 500
return (
jsonify(
status="ok",
status=HealthStatus.OK.value,
api=api_status,
git_commit=version.__git_commit__,
build_time=version.__time__,
@@ -76,7 +77,7 @@ def show_redis_status():
)
return (
jsonify(
status=f"error: {err}",
status=f"{HealthStatus.ERROR.value}: {err}",
api=api_status,
git_commit=version.__git_commit__,
build_time=version.__time__,