darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

PART 1: Created and implemented enums throughout the codebase to replace hardcoded status strings, improving type safety and reducing the risk of typos.

Browse Source
This commit is contained in:
Beverly Nguyen
2025-07-04 16:37:04 -07:00
parent db20c888f2
commit b73b4ac73e
12 changed files with 132 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/notify_client/invite_api_client.py
View File

@@ -11,6 +11,7 @@ from app.utils.user_permissions import (
translate_permissions_from_ui_to_db,
)
from notifications_utils.url_safe_token import generate_token
from app.enums import InvitedUserStatus
class InviteApiClient(NotifyAdminAPIClient):
@@ -94,7 +95,7 @@ class InviteApiClient(NotifyAdminAPIClient):
return self.get(url=f"/invite/service/check/{token}")["data"]
def cancel_invited_user(self, service_id, invited_user_id):
data = {"status": "cancelled"}
data = {"status": InvitedUserStatus.CANCELLED.value}
data = _attach_current_user(data)
self.post(url=f"/service/{service_id}/invite/{invited_user_id}", data=data)
@@ -131,7 +132,7 @@ class InviteApiClient(NotifyAdminAPIClient):
@cache.delete("service-{service_id}")
@cache.delete("user-{invited_user_id}")
def accept_invite(self, service_id, invited_user_id):
data = {"status": "accepted"}
data = {"status": InvitedUserStatus.ACCEPTED.value}
self.post(url=f"/service/{service_id}/invite/{invited_user_id}", data=data)