darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-02 23:20:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add event tracking to window.GOVUK.analytics

Browse Source 
app/assets/javascripts/errorTracking.js sent
events to `window.ga`.

This extends the API of `window.GOVUK.Analytics`
to include support for sending events so all
calls to `window.ga` can use it instead of direct
access.

This use of `window.ga` was missed from the
initial work on `window.GOVUK.Anaytics`.
This commit is contained in:
Tom Byers
2020-01-10 11:02:17 +00:00
parent 3972a52aab
commit b6e37a6ac8
4 changed files with 73 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/javascripts/analytics/analytics.test.js
View File

@@ -37,7 +37,7 @@ describe("Analytics", () => {
afterEach(() => {
window.ga.mockReset();
window.ga.mockClear();
});
@@ -58,10 +58,15 @@ describe("Analytics", () => {
describe("When tracking pageviews", () => {
test("It sends the right URL for the page if no arguments", () => {
beforeEach(() => {
// clear calls to window.ga from set up
window.ga.mockClear();
});
test("It sends the right URL for the page if no arguments", () => {
jest.spyOn(window, 'location', 'get').mockImplementation(() => {
return {
'pathname': '/privacy',
@@ -77,8 +82,6 @@ describe("Analytics", () => {
test("It strips the UUIDs from URLs", () => {
window.ga.mockClear();
jest.spyOn(window, 'location', 'get').mockImplementation(() => {
return {
'pathname': '/services/6658542f-0cad-491f-bec8-ab8457700ead',
@@ -94,4 +97,29 @@ describe("Analytics", () => {
});
describe("When tracking events", () => {
beforeEach(() => {
// clear calls to window.ga from set up
window.ga.mockClear();
});
test("It sends the right arguments to `ga`", () => {
analytics.trackEvent('Error', 'Enter a valid email address', {
'label': 'email_address'
});
expect(window.ga.mock.calls[0]).toEqual(['send', 'event', {
'eventCategory': 'Error',
'eventAction': 'Enter a valid email address',
'eventLabel': 'email_address'
}]);
});
});
});

13
tests/javascripts/errorTracking.test.js
View File

@@ -18,18 +18,23 @@ describe('Error tracking', () => {
afterEach(() => {
document.body.innerHTML = '';
delete window.GOVUK.analytics;
});
test("It should send the right data to Google Analytics", () => {
test("If there is an analytics tracker set up, it should send details of the error to window.GOVUK.analytic", () => {
window.ga = jest.fn(() => {});
window.GOVUK.analytics = {
'trackEvent': jest.fn()
};
// start the module
window.GOVUK.modules.start();
expect(window.ga).toHaveBeenCalled();
expect(window.ga.mock.calls[0]).toEqual(['send', 'event', 'Error', 'validation', 'missing field']);
expect(window.GOVUK.analytics.trackEvent).toHaveBeenCalled();
expect(window.GOVUK.analytics.trackEvent.mock.calls[0]).toEqual(['Error', 'validation', {
'label': 'missing field'
}]);
});