From b643aa54eccd8caa770c19e493d36ca86ddf868f Mon Sep 17 00:00:00 2001 From: Pea Tyczynska Date: Wed, 24 Apr 2019 10:27:57 +0100 Subject: [PATCH] Basic reports page, returns 200 and is visible in PA sidebar --- app/main/views/platform_admin.py | 9 +++++++++ app/navigation.py | 4 ++++ .../views/platform-admin/_base_template.html | 1 + app/templates/views/platform-admin/reports.html | 13 +++++++++++++ tests/app/main/views/test_platform_admin.py | 13 +++++++++++++ 5 files changed, 40 insertions(+) create mode 100644 app/templates/views/platform-admin/reports.html diff --git a/app/main/views/platform_admin.py b/app/main/views/platform_admin.py index e40e33f15..2e3464bba 100644 --- a/app/main/views/platform_admin.py +++ b/app/main/views/platform_admin.py @@ -187,6 +187,15 @@ def platform_admin_services(): ) +@main.route("/platform-admin/reports") +@login_required +@user_is_platform_admin +def platform_admin_reports(): + return render_template( + 'views/platform-admin/reports.html' + ) + + @main.route("/platform-admin/complaints") @login_required @user_is_platform_admin diff --git a/app/navigation.py b/app/navigation.py index 829a50489..14d054015 100644 --- a/app/navigation.py +++ b/app/navigation.py @@ -89,6 +89,7 @@ class HeaderNavigation(Navigation): 'platform_admin', 'platform_admin_letter_validation_preview', 'platform_admin_list_complaints', + 'platform_admin_reports', 'platform_admin_returned_letters', 'suspend_service', 'trial_services', @@ -493,6 +494,7 @@ class MainNavigation(Navigation): 'platform_admin', 'platform_admin_letter_validation_preview', 'platform_admin_list_complaints', + 'platform_admin_reports', 'platform_admin_returned_letters', 'pricing', 'privacy', @@ -706,6 +708,7 @@ class CaseworkNavigation(Navigation): 'organisations', 'platform_admin_letter_validation_preview', 'platform_admin_list_complaints', + 'platform_admin_reports', 'platform_admin_returned_letters', 'platform_admin', 'pricing', @@ -960,6 +963,7 @@ class OrgNavigation(Navigation): 'platform_admin', 'platform_admin_letter_validation_preview', 'platform_admin_list_complaints', + 'platform_admin_reports', 'platform_admin_returned_letters', 'pricing', 'privacy', diff --git a/app/templates/views/platform-admin/_base_template.html b/app/templates/views/platform-admin/_base_template.html index 90022f895..ef7fa200c 100644 --- a/app/templates/views/platform-admin/_base_template.html +++ b/app/templates/views/platform-admin/_base_template.html @@ -17,6 +17,7 @@ ('Trial mode services', url_for('main.trial_services')), ('Organisations', url_for('main.organisations')), ('Providers', url_for('main.view_providers')), + ('Reports', url_for('main.platform_admin_reports')), ('Email branding', url_for('main.email_branding')), ('Letter branding', url_for('main.letter_branding')), ('Inbound SMS numbers', url_for('main.inbound_sms_admin')), diff --git a/app/templates/views/platform-admin/reports.html b/app/templates/views/platform-admin/reports.html new file mode 100644 index 000000000..76bdec6e7 --- /dev/null +++ b/app/templates/views/platform-admin/reports.html @@ -0,0 +1,13 @@ +{% extends "views/platform-admin/_base_template.html" %} + +{% block per_page_title %} + Platform admin +{% endblock %} + +{% block platform_admin_content %} + +

+ Reports +

+ +{% endblock %} diff --git a/tests/app/main/views/test_platform_admin.py b/tests/app/main/views/test_platform_admin.py index 87a0f90b9..d04ac7115 100644 --- a/tests/app/main/views/test_platform_admin.py +++ b/tests/app/main/views/test_platform_admin.py @@ -927,3 +927,16 @@ def test_clear_cache_requires_option(client_request, platform_admin_user, mocker assert normalize_spaces(page.find('span', class_='error-message').text) == 'Not a valid choice' assert not redis.delete_cache_keys_by_pattern.called + + +def test_reports_page( + client, + platform_admin_user, + mocker, +): + mock_get_user(mocker, user=platform_admin_user) + client.login(platform_admin_user) + response = client.get(url_for('main.platform_admin_reports')) + + assert response.status_code == 200 + response.get_data(as_text=True)