From b5d279e890bc398114f3010c7dbf69bb6f7d4993 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 16 Mar 2020 15:07:34 +0000 Subject: [PATCH] Redirect to uploads after save contact list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The saved uploads page just shows you the same thing you’ve seen on the previous page – a list of email addresses. It’s more useful to see the uploads page, so you can see where the thing you’ve saved has gone. You can see it more in context. --- app/main/views/uploads.py | 3 +-- tests/app/main/views/test_uploads.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/main/views/uploads.py b/app/main/views/uploads.py index e3c6d09ad..4398152eb 100644 --- a/app/main/views/uploads.py +++ b/app/main/views/uploads.py @@ -429,9 +429,8 @@ def check_contact_list(service_id, upload_id): def save_contact_list(service_id, upload_id): ContactList.create(current_service.id, upload_id) return redirect(url_for( - '.contact_list', + '.uploads', service_id=current_service.id, - contact_list_id=upload_id, )) diff --git a/tests/app/main/views/test_uploads.py b/tests/app/main/views/test_uploads.py index 13daaf5dc..980b087e5 100644 --- a/tests/app/main/views/test_uploads.py +++ b/tests/app/main/views/test_uploads.py @@ -1138,9 +1138,8 @@ def test_save_contact_list( upload_id=fake_uuid, _expected_status=302, _expected_redirect=url_for( - 'main.contact_list', + 'main.uploads', service_id=SERVICE_ONE_ID, - contact_list_id=fake_uuid, _external=True, ) )