From b3bc3a6447b1cfcc2bb41af0fbd6b14ba113a6da Mon Sep 17 00:00:00 2001
From: Pea Tyczynska <pea.tyczynska@digital.cabinet-office.gov.uk>
Date: Wed, 1 Jul 2020 12:16:32 +0100
Subject: [PATCH] Write test for separate page for service name change for
 local orgs

Also make a bullet list gov uk style
---
 app/main/views/add_service.py                 |  1 +
 app/templates/views/add-service-local.html    |  4 ++--
 tests/app/main/views/test_service_settings.py | 20 +++++++++++++++++++
 3 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/app/main/views/add_service.py b/app/main/views/add_service.py
index 3b9f563e2..e5442e7d9 100644
--- a/app/main/views/add_service.py
+++ b/app/main/views/add_service.py
@@ -87,6 +87,7 @@ def add_service():
                 heading=heading,
                 default_organisation_type=default_organisation_type,
             )
+
         return render_template(
             'views/add-service.html',
             form=form,
diff --git a/app/templates/views/add-service-local.html b/app/templates/views/add-service-local.html
index 7db2fd733..1ce590ec6 100644
--- a/app/templates/views/add-service-local.html
+++ b/app/templates/views/add-service-local.html
@@ -17,13 +17,13 @@
     {{ page_header('About your service') }}
 
     <p class="govuk-body">Give your service a name that tells users what your messages are about, as well as who they’re from. For example:</p>
-        <ul class="list-bullet">
+        <ul class="govuk-list govuk-list--bullet">
           <li>School admissions - {{ current_user.default_organisation.name }}</li>
           <li>Electoral services - {{ current_user.default_organisation.name }}</li>
           <li>Blue Badge - {{ current_user.default_organisation.name }}</li>
         </ul>
         <p class="govuk-body">You should only use an acronym if your users are already familiar with it.</p>
-    
+
     {% call form_wrapper() %}
 
       {{ textbox(form.name, hint="You can change this later") }}
diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py
index 028ef989f..3e96b60ab 100644
--- a/tests/app/main/views/test_service_settings.py
+++ b/tests/app/main/views/test_service_settings.py
@@ -383,6 +383,26 @@ def test_should_show_service_name(
     app.service_api_client.get_service.assert_called_with(SERVICE_ONE_ID)
 
 
+def test_should_show_different_change_service_name_page_for_local_services(
+    client_request,
+    service_one,
+    mocker,
+):
+    mocker.patch(
+        'app.organisations_client.get_organisation_by_domain',
+        return_value=organisation_json(organisation_type='local'),
+    )
+    service_one['organisation_type'] = 'local'
+    page = client_request.get('main.service_name_change', service_id=SERVICE_ONE_ID)
+    assert page.find('h1').text == 'Change your service name'
+    assert page.find('input', attrs={"type": "text"})['value'] == 'service one'
+    assert page.select_one('main .govuk-body').text.strip() == (
+        'Your service name should tell users what the message is about as well as who it’s from. For example:'
+    )
+
+    app.service_api_client.get_service.assert_called_with(SERVICE_ONE_ID)
+
+
 def test_should_show_service_name_with_no_prefixing(
     client_request,
     service_one,