darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 10:03:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use str.join to build query

Browse Source 
This avoids the nasty slice operator to trim the trailing comma.
This commit is contained in:
Chris Hill-Scott
2021-08-06 10:14:15 +01:00
parent de364bba3c
commit b273037462
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/broadcast_areas/repo.py
View File

@@ -130,7 +130,7 @@ class BroadcastAreasRepository(object):
SELECT id, name, count_of_phones, broadcast_area_library_id SELECT id, name, count_of_phones, broadcast_area_library_id
FROM broadcast_areas FROM broadcast_areas
WHERE id IN ({}) WHERE id IN ({})
""".format(("?," * len(area_ids))[:-1]) """.format(",".join("?" * len(area_ids)))
results = self.query(q, *area_ids) results = self.query(q, *area_ids)
@@ -147,7 +147,7 @@ class BroadcastAreasRepository(object):
FROM broadcast_areas FROM broadcast_areas
JOIN broadcast_area_polygons on broadcast_area_polygons.id = broadcast_areas.id JOIN broadcast_area_polygons on broadcast_area_polygons.id = broadcast_areas.id
WHERE broadcast_areas.id IN ({}) WHERE broadcast_areas.id IN ({})
""".format(("?," * len(area_ids))[:-1]) """.format(",".join("?" * len(area_ids)))
results = self.query(q, *area_ids) results = self.query(q, *area_ids)