darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-17 21:19:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change the content for the delete template confirmation dialog.

Browse Source 
As per https://www.pivotaltracker.com/story/show/170796514 we want to make the delete template confirmation dialog box more consistent and clear.
The API has been updated with a new endpoint that only returns the last-used date, this date is more accurate since it goes to the ft_notification_status table, if the notification table is empty.
This commit is contained in:
Rebecca Law
2020-02-05 13:52:46 +00:00
parent 143564c7f0
commit b242467d77
6 changed files with 15 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/notify_client/test_template_statistics_client.py
View File

@@ -22,11 +22,11 @@ def test_template_statistics_client_calls_correct_api_endpoint_for_service(mocke
def test_template_statistics_client_calls_correct_api_endpoint_for_template(mocker, api_user_active):
some_service_id = uuid.uuid4()
some_template_id = uuid.uuid4()
expected_url = '/service/{}/template-statistics/{}'.format(some_service_id, some_template_id)
expected_url = '/service/{}/template-statistics/last-used/{}'.format(some_service_id, some_template_id)
client = TemplateStatisticsApiClient()
mock_get = mocker.patch('app.notify_client.template_statistics_api_client.TemplateStatisticsApiClient.get')
client.get_template_statistics_for_template(some_service_id, some_template_id)
client.get_last_used_date_for_template(some_service_id, some_template_id)
mock_get.assert_called_once_with(url=expected_url)