From d0a0b17f7bff15befd69310c718a3e977d31cfba Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 16 Jul 2019 15:49:00 +0100 Subject: [PATCH 01/12] Update trial mode content --- app/templates/views/service-settings.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index a74a91d58..f1716bc27 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -260,7 +260,7 @@

{% if current_user.has_permissions('manage_service') %} - To remove these restrictions + To remove these restrictions, you can send us a request to go live. {% else %} Your service manager can ask to have these restrictions removed. From 7e26d8a5cde8427658abf195c3ae9a6bc3ba1312 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 16 Jul 2019 15:50:52 +0100 Subject: [PATCH 02/12] Remove quote marks --- app/templates/views/service-settings/letter-contact/add.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/letter-contact/add.html b/app/templates/views/service-settings/letter-contact/add.html index 6f6e488c7..e284fa62d 100644 --- a/app/templates/views/service-settings/letter-contact/add.html +++ b/app/templates/views/service-settings/letter-contact/add.html @@ -20,7 +20,7 @@ {% call form_wrapper() %} {{ textbox( form.letter_contact_block, - label='This will appear as the ‘sender’ address on your letters.'|safe, + label='This will appear as the sender address on your letters.'|safe, hint='10 lines maximum', width='1-2', rows=10, From 8a323479d85737abbc855cec6e1c92dc9de6b5d1 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 16 Jul 2019 15:51:38 +0100 Subject: [PATCH 03/12] Remove quote marks --- app/templates/views/service-settings/letter-contact/edit.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/letter-contact/edit.html b/app/templates/views/service-settings/letter-contact/edit.html index 8c17b67b6..02ba9b3c4 100644 --- a/app/templates/views/service-settings/letter-contact/edit.html +++ b/app/templates/views/service-settings/letter-contact/edit.html @@ -18,7 +18,7 @@ {% call form_wrapper() %} {{ textbox( form.letter_contact_block, - label='This will appear as the ‘sender’ address on your letters.'|safe, + label='This will appear as the sender address on your letters.'|safe, hint='10 lines maximum', width='1-2', rows=10, From 59bb156881a4798f715f5a5fa19e54d31b772909 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 16 Jul 2019 16:05:42 +0100 Subject: [PATCH 04/12] Remove example MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removed `eg ‘{service name}: This is an example message’ – the content is already self explanatory --- app/templates/views/service-settings/name.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/name.html b/app/templates/views/service-settings/name.html index 5190b4298..a10f3deff 100644 --- a/app/templates/views/service-settings/name.html +++ b/app/templates/views/service-settings/name.html @@ -20,7 +20,7 @@ {% if current_service.prefix_sms %}

Users will see your service name:

{% else %} From cf11b3e3c8baf311c235b941cc82cf8c5d062b54 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 16 Jul 2019 16:15:42 +0100 Subject: [PATCH 05/12] Change 'info' to 'information' --- .../views/service-settings/branding/email-options.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/branding/email-options.html b/app/templates/views/service-settings/branding/email-options.html index c0ea4ff81..d93bb660d 100644 --- a/app/templates/views/service-settings/branding/email-options.html +++ b/app/templates/views/service-settings/branding/email-options.html @@ -39,7 +39,7 @@

We’ll email you once your branding’s ready to use, or if we need any - more info. + more information.

{{ page_footer('Request new branding') }} {% endcall %} From c35802f4e7651efb5fe2063fa2143f1000cd7be4 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 22 Jul 2019 10:06:57 +0100 Subject: [PATCH 06/12] Add full stop --- app/templates/views/service-settings/sms-sender/edit.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/sms-sender/edit.html b/app/templates/views/service-settings/sms-sender/edit.html index c8a249401..aad6a3538 100644 --- a/app/templates/views/service-settings/sms-sender/edit.html +++ b/app/templates/views/service-settings/sms-sender/edit.html @@ -31,7 +31,7 @@ {% endif %} {% if form.is_default.data %}

- This is the default text message sender + This is the default text message sender.

{{ page_footer('Save') }} {% else %} From 71cbc787de5990f4c81962cc8f2d24de3d7529c9 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 22 Jul 2019 10:11:31 +0100 Subject: [PATCH 07/12] Update page title and header --- app/templates/views/service-settings/sms-prefix.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/templates/views/service-settings/sms-prefix.html b/app/templates/views/service-settings/sms-prefix.html index 65147907b..02b6daa04 100644 --- a/app/templates/views/service-settings/sms-prefix.html +++ b/app/templates/views/service-settings/sms-prefix.html @@ -5,13 +5,13 @@ {% from "components/form.html" import form_wrapper %} {% block service_page_title %} - Text messages start with service name + Start text messages with service name {% endblock %} {% block maincolumn_content %} {{ page_header( - 'Text messages start with service name', + 'Start text messages with service name', back_link=url_for('main.service_settings', service_id=current_service.id) ) }} From 3e179e49eb7dcebc10ffa07612a61aa5d76932fd Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 22 Jul 2019 10:13:33 +0100 Subject: [PATCH 08/12] Update text message setting name Update text message setting name for `Start text messages with service name` --- app/templates/views/service-settings.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index f1716bc27..9f4e75569 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -153,7 +153,7 @@ {% endcall %} {% call settings_row(if_has_permission='sms') %} - {{ text_field('Text messages start with service name') }} + {{ text_field('Start text messages with service name') }} {{ boolean_field(current_service.prefix_sms) }} {{ edit_field( 'Change', From 749ce73d78d7ec9e0f0908082ce2c2facdc783af Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 22 Jul 2019 10:21:25 +0100 Subject: [PATCH 09/12] Update content --- app/templates/views/service-settings/set-inbound-sms.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/templates/views/service-settings/set-inbound-sms.html b/app/templates/views/service-settings/set-inbound-sms.html index be36f4243..0cfab5267 100644 --- a/app/templates/views/service-settings/set-inbound-sms.html +++ b/app/templates/views/service-settings/set-inbound-sms.html @@ -33,10 +33,10 @@ Contact us if you want to be able to receive text messages from your users.

- We’ll create a special phone number for your users to contact. You'll be able to see + We’ll create a special phone number for them to contact. You'll be able to see the messages on your dashboard, or get them using the API.

- It doesn’t cost you anything to receive messages. Users will pay their normal rate for + It does not cost you anything to receive text messages. Users will pay their normal rate for messaging a mobile number.

{% endif %} From db5bf977eea5af9750cb7cacb400166eacb4668a Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 22 Jul 2019 10:24:43 +0100 Subject: [PATCH 10/12] Add full stop --- app/templates/views/service-settings/letter-contact/edit.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/letter-contact/edit.html b/app/templates/views/service-settings/letter-contact/edit.html index 02ba9b3c4..4ca84f18a 100644 --- a/app/templates/views/service-settings/letter-contact/edit.html +++ b/app/templates/views/service-settings/letter-contact/edit.html @@ -28,7 +28,7 @@ {% if form.is_default.data %}

- This is the default address for {{ current_service.name }} + This is currently your default address for {{ current_service.name }}.

{% else %}
From eb166c60cf2f600bf01d7d5e231b674239ce387e Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Mon, 22 Jul 2019 10:30:56 +0100 Subject: [PATCH 11/12] Update contact us link content --- .../views/service-settings/request-letter-branding.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/views/service-settings/request-letter-branding.html b/app/templates/views/service-settings/request-letter-branding.html index 91f22be97..508182001 100644 --- a/app/templates/views/service-settings/request-letter-branding.html +++ b/app/templates/views/service-settings/request-letter-branding.html @@ -21,7 +21,7 @@ Your letters have the {{ current_service.letter_branding.name }} logo.

- Contact support + Contact us if you want to use a different logo.

{% else %} From cc29764d43fcd093fb24c0a0c734780cf75efdf1 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Wed, 24 Jul 2019 11:55:45 +0100 Subject: [PATCH 12/12] Update unit test for the content changes. --- tests/app/main/views/test_service_settings.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index d983490ff..8f9b76d7b 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -71,7 +71,7 @@ def mock_get_service_settings_page_common( 'Label Value Action', 'Send text messages On Change', 'Text message sender GOVUK Change', - 'Text messages start with service name On Change', + 'Start text messages with service name On Change', 'International text messages Off Change', 'Receive text messages Off Change', @@ -93,7 +93,7 @@ def mock_get_service_settings_page_common( 'Label Value Action', 'Send text messages On Change', 'Text message sender GOVUK Change', - 'Text messages start with service name On Change', + 'Start text messages with service name On Change', 'International text messages Off Change', 'Receive text messages Off Change', @@ -207,7 +207,7 @@ def test_organisation_name_links_to_org_dashboard( 'Label Value Action', 'Send text messages On Change', 'Text message sender GOVUK Change', - 'Text messages start with service name On Change', + 'Start text messages with service name On Change', 'International text messages On Change', 'Receive text messages On Change', @@ -228,7 +228,7 @@ def test_organisation_name_links_to_org_dashboard( 'Label Value Action', 'Send text messages On Change', 'Text message sender GOVUK Change', - 'Text messages start with service name On Change', + 'Start text messages with service name On Change', 'International text messages Off Change', 'Receive text messages Off Change', @@ -341,7 +341,7 @@ def test_should_show_service_name( assert page.find('input', attrs={"type": "text"})['value'] == 'service one' assert page.select_one('main p').text == 'Users will see your service name:' assert normalize_spaces(page.select_one('main ul').text) == ( - 'at the start of every text message, eg ‘service one: This is an example message’ ' + 'at the start of every text message ' 'as your email sender name' ) app.service_api_client.get_service.assert_called_with(SERVICE_ONE_ID) @@ -400,7 +400,7 @@ def test_should_not_hit_api_if_service_name_hasnt_changed( @pytest.mark.parametrize('user, expected_text, expected_link', [ ( active_user_with_permissions, - 'To remove these restrictions request to go live.', + 'To remove these restrictions, you can send us a request to go live.', True, ), ( @@ -2594,7 +2594,7 @@ def test_edit_sms_sender( ( 'main.service_edit_letter_contact', get_default_letter_contact_block, - 'This is the default address for service one', + 'This is currently your default address for service one.', 'letter_contact_id', False ), @@ -2608,14 +2608,14 @@ def test_edit_sms_sender( ( 'main.service_edit_sms_sender', get_default_sms_sender, - 'This is the default text message sender', + 'This is the default text message sender.', 'sms_sender_id', False ), ( 'main.service_edit_sms_sender', get_non_default_sms_sender, - 'This is the default text message sender', + 'This is the default text message sender.', 'sms_sender_id', True )