darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 08:28:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

notify-admin-916 revert restrictions on create service

Browse Source
This commit is contained in:
Kenneth Kehl
2023-11-14 07:51:56 -08:00
parent 6df7770ee1
commit b1bd51730d
2 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/add_service.py
View File

@@ -6,7 +6,7 @@ from app import service_api_client
from app.formatters import email_safe from app.formatters import email_safe
from app.main import main from app.main import main
from app.main.forms import CreateServiceForm from app.main.forms import CreateServiceForm
from app.utils.user import user_is_gov_user, user_is_platform_admin from app.utils.user import user_is_gov_user, user_is_logged_in
def _create_service(service_name, organization_type, email_from, form): def _create_service(service_name, organization_type, email_from, form):
@@ -42,7 +42,7 @@ def _create_example_template(service_id):
@main.route("/add-service", methods=["GET", "POST"]) @main.route("/add-service", methods=["GET", "POST"])
@user_is_gov_user @user_is_gov_user
@user_is_platform_admin @user_is_logged_in
def add_service(): def add_service():
default_organization_type = current_user.default_organization_type default_organization_type = current_user.default_organization_type
if default_organization_type is None: if default_organization_type is None:

15
tests/app/main/views/test_sign_in.py
View File

@@ -4,7 +4,7 @@ import pytest
from flask import url_for from flask import url_for
from app.models.user import User from app.models.user import User
from tests.conftest import SERVICE_ONE_ID, create_platform_admin_user, normalize_spaces from tests.conftest import SERVICE_ONE_ID, normalize_spaces
def test_render_sign_in_template_for_new_user(client_request): def test_render_sign_in_template_for_new_user(client_request):
@@ -72,19 +72,6 @@ def test_doesnt_redirect_to_sign_in_if_no_session_info(
with client_request.session_transaction() as session: with client_request.session_transaction() as session:
session["current_session_id"] = None session["current_session_id"] = None
# This returns a 403 now
with pytest.raises(AssertionError):
client_request.get("main.add_service")
def test_doesnt_redirect_to_sign_in_if_no_session_info_platform_admin(
client_request,
mock_get_organization_by_domain,
):
platform_admin = create_platform_admin_user()
client_request.login(platform_admin)
platform_admin["current_session_id"] = str(uuid.UUID(int=1))
with client_request.session_transaction() as session: with client_request.session_transaction() as session:
session["current_session_id"] = None session["current_session_id"] = None