darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix significant figure round for value of 0

Browse Source 
You can’t do `log10(0)` in maths, so we need to handle it as a special
case.
This commit is contained in:
Chris Hill-Scott
2020-09-17 11:08:36 +01:00
parent ba9f786971
commit ae17ff1f07
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/app/test_utils.py
View File

@@ -23,6 +23,7 @@ from app.utils import (
is_less_than_90_days_ago,
merge_jsonlike,
printing_today_or_tomorrow,
round_to_significant_figures,
)
from tests.conftest import fake_uuid
@@ -631,3 +632,18 @@ def test_get_sample_template_returns_template(template_type):
def test_merge_jsonlike_merges_jsonlike_objects_correctly(source_object, destination_object, expected_result):
merge_jsonlike(source_object, destination_object)
assert source_object == expected_result
@pytest.mark.parametrize('value, significant_figures, expected_result', (
(0, 1, 0),
(0, 2, 0),
(12_345, 1, 10_000),
(12_345, 2, 12_000),
(12_345, 3, 12_300),
(12_345, 9, 12_345),
(12_345.6789, 1, 10_000),
(12_345.6789, 9, 12_345),
(-12_345, 1, -10_000),
))
def test_round_to_significant_figures(value, significant_figures, expected_result):
assert round_to_significant_figures(value, significant_figures) == expected_result