From acfe87e7888e02f5d661be8bacfc63f468d7362c Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 2 Jun 2016 10:41:54 +0100 Subject: [PATCH] Use `hasattr` instead of `getattr` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We don’t need the value returned by `getattr`, so using `hasattr` is cleaner. --- app/main/views/templates.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/main/views/templates.py b/app/main/views/templates.py index b79a5dc03..01230f27a 100644 --- a/app/main/views/templates.py +++ b/app/main/views/templates.py @@ -113,7 +113,7 @@ def edit_service_template(service_id, template_id): form = form_objects[template['template_type']](**template) if form.validate_on_submit(): - subject = form.subject.data if getattr(form, 'subject', None) else None + subject = form.subject.data if hasattr(form, 'subject') else None new_template = Template({ 'name': form.name.data, 'content': form.template_content.data,