diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index 99cb32788..aba1b0bd5 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -61,9 +61,10 @@ suffix='your settings for sending text messages', )}} {% endcall %} - + + {% if current_user.platform_admin %} {% call settings_row(if_has_permission='sms') %} - {{ text_field('Text message senders') }} + {{ text_field('Text message senders\n(Only visible to Platform Admins)') }} {% call field(status='default' if current_service.default_sms_sender == "None" else '') %} {{ current_service.default_sms_sender | nl2br if current_service.default_sms_sender else 'None'}} {% if current_service.count_sms_senders > 1 %} @@ -80,7 +81,8 @@ ) }} {% endcall %} - + {% endif %} + {% call settings_row(if_has_permission='sms') %} {{ text_field('Start text messages with service name') }} {{ boolean_field(current_service.prefix_sms) }} diff --git a/tests/app/main/views/service_settings/test_service_settings.py b/tests/app/main/views/service_settings/test_service_settings.py index df8f90243..c17971060 100644 --- a/tests/app/main/views/service_settings/test_service_settings.py +++ b/tests/app/main/views/service_settings/test_service_settings.py @@ -57,7 +57,6 @@ def mock_get_service_settings_page_common( 'Service name Test Service Change service name', 'Sign-in method Text message code Change sign-in method', 'Send text messages On Change your settings for sending text messages', - 'Text message senders GOVUK Manage text message senders', 'Start text messages with service name On Change your settings for starting text messages with service name', 'Send international text messages Off Change your settings for sending international text messages', @@ -68,7 +67,7 @@ def mock_get_service_settings_page_common( 'Service name Test Service Change service name', 'Sign-in method Text message code Change sign-in method', 'Send text messages On Change your settings for sending text messages', - 'Text message senders GOVUK Manage text message senders', + 'Text message senders (Only visible to Platform Admins) GOVUK Manage text message senders', 'Start text messages with service name On Change your settings for starting text messages with service name', 'Send international text messages Off Change your settings for sending international text messages', @@ -111,7 +110,6 @@ def test_should_show_overview( page = client_request.get( 'main.service_settings', service_id=SERVICE_ONE_ID ) - assert page.find('h1').text == 'Settings' rows = page.select('tr') assert len(rows) == len(expected_rows) @@ -205,7 +203,6 @@ def test_send_files_by_email_row_on_settings_page( 'Service name service one Change service name', 'Sign-in method Text message code Change sign-in method', 'Send text messages On Change your settings for sending text messages', - 'Text message senders GOVUK Manage text message senders', 'Start text messages with service name On Change your settings for starting text messages with service name', 'Send international text messages On Change your settings for sending international text messages', @@ -216,7 +213,6 @@ def test_send_files_by_email_row_on_settings_page( 'Service name service one Change service name', 'Sign-in method Email link or text message code Change sign-in method', 'Send text messages On Change your settings for sending text messages', - 'Text message senders GOVUK Manage text message senders', 'Start text messages with service name On Change your settings for starting text messages with service name', 'Send international text messages Off Change your settings for sending international text messages',