From 369307f45a1fc23afc0c213be943a1f1710676dd Mon Sep 17 00:00:00 2001 From: alexjanousekGSA Date: Mon, 13 Jan 2025 16:07:32 -0500 Subject: [PATCH 1/4] More test fixes --- app/navigation.py | 6 ------ tests/app/main/views/test_index.py | 4 ---- tests/app/test_navigation.py | 1 - 3 files changed, 11 deletions(-) diff --git a/app/navigation.py b/app/navigation.py index 271d6848b..3bd04f7b5 100644 --- a/app/navigation.py +++ b/app/navigation.py @@ -40,12 +40,6 @@ class HeaderNavigation(Navigation): "support": { "support", }, - "features": { - "features", - "features_sms", - "roadmap", - "security", - }, "best_practices": { "best_practices", "clear_goals", diff --git a/tests/app/main/views/test_index.py b/tests/app/main/views/test_index.py index 26f3d529a..db166d21e 100644 --- a/tests/app/main/views/test_index.py +++ b/tests/app/main/views/test_index.py @@ -176,10 +176,6 @@ def test_old_static_pages_redirect(client_request, view, expected_view, mocker): ) -def test_old_using_notify_page(client_request): - client_request.get("main.using_notify", _expected_status=410) - - def test_css_is_served_from_correct_path(client_request): page = client_request.get("main.documentation") # easy static page diff --git a/tests/app/test_navigation.py b/tests/app/test_navigation.py index 8b9ade8c7..cfc3c73b5 100644 --- a/tests/app/test_navigation.py +++ b/tests/app/test_navigation.py @@ -95,7 +95,6 @@ EXCLUDED_ENDPOINTS = tuple( "error", "establish_trust", "features", - "features_sms", "find_services_by_name", "find_users_by_email", "forgot_password", From 9666740af9e00bcd15173744a9e79864baf31395 Mon Sep 17 00:00:00 2001 From: alexjanousekGSA Date: Tue, 14 Jan 2025 09:17:01 -0500 Subject: [PATCH 2/4] Fixing tests --- app/main/views/index.py | 2 - app/templates/views/roadmap.html | 87 -------------------------------- tests/app/test_navigation.py | 3 -- 3 files changed, 92 deletions(-) delete mode 100644 app/templates/views/roadmap.html diff --git a/app/main/views/index.py b/app/main/views/index.py index b45c699e7..466a2dea5 100644 --- a/app/main/views/index.py +++ b/app/main/views/index.py @@ -309,14 +309,12 @@ def studio(): # --- Redirects --- # -@main.route("/roadmap", endpoint="old_roadmap") @main.route("/information-security", endpoint="information_security") @main.route("/using_notify", endpoint="old_using_notify") @main.route("/information-risk-management", endpoint="information_risk_management") @main.route("/integration_testing", endpoint="old_integration_testing") def old_page_redirects(): redirects = { - "main.old_roadmap": "main.roadmap", "main.information_security": "main.using_notify", "main.old_using_notify": "main.using_notify", "main.information_risk_management": "main.security", diff --git a/app/templates/views/roadmap.html b/app/templates/views/roadmap.html deleted file mode 100644 index f9446aad5..000000000 --- a/app/templates/views/roadmap.html +++ /dev/null @@ -1,87 +0,0 @@ -{% extends "base.html" %} -{% from "components/table.html" import mapping_table, row, text_field, edit_field, field with context %} -{% from "components/content-metadata.html" import content_metadata %} - -{% block per_page_title %} - Roadmap -{% endblock %} - -{% block content_column_content %} - -

Roadmap

- - - - -

The Notify roadmap shows what we’re working on and what we're planning to do next.

-

This roadmap is only a guide. It does not cover everything we do, and some things may change.

-

You can contact us if you have any questions about the roadmap or suggestions for new features.

- -

What we’re working on

- -

Now

- -

We are investigating the Notify concept, building on the notifications tool pioneered by the UK.

-

To do this, we are convening a pilot with a small set of partners.

-

Goals during this stage:

- - - -

Features prioritized during this stage:

- - - -

Next

- -

If the pilot is successful, we hope to recruit additional partners to improve outcomes for low-income individuals and families.

- -

Goals during this stage:

- - - -

Features prioritized during this stage:

- - - -

Later

- -

In the future, we may decide to expand beyond SMS, or to offer the service government-wide.

- -

Features to be considered during this stage:

- - - -{% endblock %} diff --git a/tests/app/test_navigation.py b/tests/app/test_navigation.py index cfc3c73b5..e11b70762 100644 --- a/tests/app/test_navigation.py +++ b/tests/app/test_navigation.py @@ -139,9 +139,7 @@ EXCLUDED_ENDPOINTS = tuple( "notifications_sent_by_service", "old_guest_list", "old_integration_testing", - "old_roadmap", "old_service_dashboard", - "old_using_notify", "organization_billing", "organization_dashboard", "organization_settings", @@ -168,7 +166,6 @@ EXCLUDED_ENDPOINTS = tuple( "resume_service", "revalidate_email_sent", "revoke_api_key", - "roadmap", "rules_and_regulations", "security", "security_policy", From cdf5d5693859159273feb012aa1467290b367910 Mon Sep 17 00:00:00 2001 From: alexjanousekGSA Date: Tue, 14 Jan 2025 09:30:52 -0500 Subject: [PATCH 3/4] Fixed more tests and pr comments --- app/templates/views/guidance/index.html | 6 ------ app/templates/views/guides/clear-goals.html | 2 +- app/templates/views/guides/rules-and-regulations.html | 4 ++-- app/templates/views/message-status.html | 2 +- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/app/templates/views/guidance/index.html b/app/templates/views/guidance/index.html index 8a8ac0e34..e93442b23 100644 --- a/app/templates/views/guidance/index.html +++ b/app/templates/views/guidance/index.html @@ -15,19 +15,14 @@ your recipient to manage their benefits and increase follow-through.

Below we explain how to:

{# Format content #}

Format your content

-

Effective texts will help your message recipients take the steps needed to secure and keep the benefits and services -they depend on. To craft an effective text:

  • Choose your messages thoughtfully. Text messages are best to remind/nudge someone to take a specific action or @@ -45,7 +40,6 @@ they depend on. To craft an effective text:

    {# Add links #} -

    When composing a text message, links to websites or online applications can help your recipient respond quickly.

      diff --git a/app/templates/views/guides/clear-goals.html b/app/templates/views/guides/clear-goals.html index 71ed0e1a3..4fe088b20 100644 --- a/app/templates/views/guides/clear-goals.html +++ b/app/templates/views/guides/clear-goals.html @@ -162,7 +162,7 @@

      Review your drafted hypothesis with your team to make sure everyone is aligned on your desired goals. A clear and - concise hypothesis can help you decide how to write text message + concise hypothesis can help you decide how to write text message content that provokes action.

      diff --git a/app/templates/views/guides/rules-and-regulations.html b/app/templates/views/guides/rules-and-regulations.html index db06ab76e..2ea07bb73 100644 --- a/app/templates/views/guides/rules-and-regulations.html +++ b/app/templates/views/guides/rules-and-regulations.html @@ -22,7 +22,7 @@ If you do need expressed consent, consider including a pre-checked plain language opt-in (i.e. “It’s OK to text me.”) on digital forms. Be sure to ask for an up-to-date phone number and include a question about the recipient’s preferred - language for text messages if you expect to translate your text + language for text messages if you expect to translate your text messages in languages other than English.

      @@ -81,7 +81,7 @@

      Opting out

      There is no policy requirement for senders to communicate opt-out options, but including instructions in introductory and/or + href="../best-practices/establish-trust#as-people-receive-texts"> including instructions in introductory and/or auto-response texts on how to opt out and opt back in are effective ways to establish trust with your audience.

      diff --git a/app/templates/views/message-status.html b/app/templates/views/message-status.html index 76ac9bb6a..243260531 100644 --- a/app/templates/views/message-status.html +++ b/app/templates/views/message-status.html @@ -77,7 +77,7 @@

      Sometimes Notify receives more detailed information from the carriers on the status of messages, and these can be found in the downloadable reports. Not all carriers provide the same level of detail regarding delivery and some delivery statutes have a slight variation in word choice. Notify includes this information in the reports to provide you as much - detail as possible. Remember, for security purposes, detailed information is only available for seven days after a + detail as possible. Remember, for security purposes, detailed information is only available for seven days after a message has been sent.

      Opting out

      From d5f4301747bd96e02bf952b87ca795e1640a6d85 Mon Sep 17 00:00:00 2001 From: alexjanousekGSA Date: Tue, 14 Jan 2025 09:55:44 -0500 Subject: [PATCH 4/4] More test fixes --- app/navigation.py | 1 - tests/app/test_navigation.py | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/navigation.py b/app/navigation.py index 3bd04f7b5..424d03ae3 100644 --- a/app/navigation.py +++ b/app/navigation.py @@ -51,7 +51,6 @@ class HeaderNavigation(Navigation): }, "using_notify": { "get_started", - "using_notify", "pricing", "trial_mode_new", "message_status", diff --git a/tests/app/test_navigation.py b/tests/app/test_navigation.py index e11b70762..5530dc270 100644 --- a/tests/app/test_navigation.py +++ b/tests/app/test_navigation.py @@ -140,6 +140,7 @@ EXCLUDED_ENDPOINTS = tuple( "old_guest_list", "old_integration_testing", "old_service_dashboard", + "old_using_notify", "organization_billing", "organization_dashboard", "organization_settings", @@ -167,7 +168,6 @@ EXCLUDED_ENDPOINTS = tuple( "revalidate_email_sent", "revoke_api_key", "rules_and_regulations", - "security", "security_policy", "send_files_by_email", "send_files_by_email_contact_details", @@ -243,7 +243,6 @@ EXCLUDED_ENDPOINTS = tuple( "user_profile_name", "user_profile_password", "user_profile_preferred_timezone", - "using_notify", "verify", "verify_email", "view_job",