darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tighten check for reply to address conflict error

Browse Source 
The check was made more permissive temporarily as we were changing
error code we are returning form API from 400 to 409.
This commit is contained in:
Pea Tyczynska
2020-04-02 12:11:14 +01:00
parent c448eb8995
commit aacd96a6b9
2 changed files with 46 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/service_settings.py
View File

@@ -391,7 +391,7 @@ def service_add_email_reply_to(service_id):
service_id, form.email_address.data
)["data"]["id"]
except HTTPError as e:
if e.status_code == 409 or e.status_code == 400:
if e.status_code == 409:
flash(e.message, 'error')
return redirect(url_for('.service_email_reply_to', service_id=service_id))
else:
@@ -518,7 +518,7 @@ def service_edit_email_reply_to(service_id, reply_to_email_id):
service_id, form.email_address.data
)["data"]["id"]
except HTTPError as e:
if e.status_code == 400 or e.status_code == 409:
if e.status_code == 409:
flash(e.message, 'error')
return redirect(url_for('.service_email_reply_to', service_id=service_id))
else: