From 476644369d5b1ef927755aa58c692cb4b6c27b49 Mon Sep 17 00:00:00 2001 From: Kenneth Kehl <@kkehl@flexion.us> Date: Thu, 24 Aug 2023 07:49:42 -0700 Subject: [PATCH] notify-admin-211 remove nhs-specific code --- app/main/views/service_settings.py | 18 --------- app/models/user.py | 8 ---- app/navigation.py | 2 - .../branding/email-branding-nhs.html | 39 ------------------- app/utils/branding.py | 2 - tests/app/test_navigation.py | 1 - 6 files changed, 70 deletions(-) delete mode 100644 app/templates/views/service-settings/branding/email-branding-nhs.html diff --git a/app/main/views/service_settings.py b/app/main/views/service_settings.py index 78c5bee1b..855233832 100644 --- a/app/main/views/service_settings.py +++ b/app/main/views/service_settings.py @@ -60,7 +60,6 @@ from app.main.forms import ( SomethingElseBrandingForm, ) from app.utils import DELIVERED_STATUSES, FAILURE_STATUSES, SENDING_STATUSES -from app.utils.branding import NHS_EMAIL_BRANDING_ID from app.utils.branding import get_email_choices as get_email_branding_choices from app.utils.time import parse_naive_dt from app.utils.user import ( @@ -924,23 +923,6 @@ def email_branding_govuk_and_org(service_id): return render_template('views/service-settings/branding/email-branding-govuk-org.html') -@main.route("/services//service-settings/email-branding/nhs", methods=['GET', 'POST']) -@user_has_permissions('manage_service') -def email_branding_nhs(service_id): - check_email_branding_allowed_for_service('nhs') - - if request.method == 'POST': - current_service.update(email_branding=NHS_EMAIL_BRANDING_ID) - - flash('You’ve updated your email branding', 'default') - return redirect(url_for('.service_settings', service_id=current_service.id)) - - return render_template( - 'views/service-settings/branding/email-branding-nhs.html', - nhs_branding_id=NHS_EMAIL_BRANDING_ID - ) - - @main.route("/services//service-settings/email-branding/organization", methods=['GET', 'POST']) @user_has_permissions('manage_service') def email_branding_organization(service_id): diff --git a/app/models/user.py b/app/models/user.py index b4a30002c..4d1b66e6f 100644 --- a/app/models/user.py +++ b/app/models/user.py @@ -347,8 +347,6 @@ class User(JSONModel, UserMixin): def default_organization_type(self): if self.default_organization: return self.default_organization.organization_type - if self.has_nhs_email_address: - return 'nhs' return None @property @@ -359,12 +357,6 @@ class User(JSONModel, UserMixin): self.trial_mode_services ) - @property - def has_nhs_email_address(self): - return self.email_address.lower().endswith(( - '@nhs.uk', '.nhs.uk', '@nhs.net', '.nhs.net', - )) - def serialize(self): dct = { "id": self.id, diff --git a/app/navigation.py b/app/navigation.py index 1fe7ba3ad..1cf3260cb 100644 --- a/app/navigation.py +++ b/app/navigation.py @@ -183,10 +183,8 @@ class MainNavigation(Navigation): }, 'settings': { # 'add_organization_from_gp_service', - # 'add_organization_from_nhs_local_service', 'email_branding_govuk', 'email_branding_govuk_and_org', - 'email_branding_nhs', 'email_branding_organization', 'email_branding_request', 'email_branding_something_else', diff --git a/app/templates/views/service-settings/branding/email-branding-nhs.html b/app/templates/views/service-settings/branding/email-branding-nhs.html deleted file mode 100644 index dd01b6b20..000000000 --- a/app/templates/views/service-settings/branding/email-branding-nhs.html +++ /dev/null @@ -1,39 +0,0 @@ -{% extends "withnav_template.html" %} -{% from "components/form.html" import form_wrapper %} -{% from "components/back-link/macro.njk" import govukBackLink %} -{% from "components/page-footer.html" import page_footer %} -{% from "components/page-header.html" import page_header %} -{% from "components/branding-preview.html" import email_branding_preview %} - -{% block service_page_title %} - Check your new branding -{% endblock %} - -{% block backLink %} - {{ govukBackLink({ - "href": url_for('.email_branding_request', service_id=current_service.id) - }) }} -{% endblock %} - -{% block maincolumn_content %} - - {{ page_header('Check your new branding') }} - -

- Emails from {{ current_service.name }} will look like this. -

- {{ email_branding_preview(nhs_branding_id) }} - -

Before you continue

- -

Make sure you’re allowed to use NHS branding.

- -

- If you’re not sure, check the guidance on the NHS website. -

- - {% call form_wrapper() %} - {{ page_footer('Use this branding') }} - {% endcall %} - -{% endblock %} diff --git a/app/utils/branding.py b/app/utils/branding.py index f1d12d77b..90f991eca 100644 --- a/app/utils/branding.py +++ b/app/utils/branding.py @@ -1,7 +1,5 @@ from app.models.organization import Organization -NHS_EMAIL_BRANDING_ID = 'a7dc4e56-660b-4db7-8cff-12c37b12b5ea' - def get_email_choices(service): organization_branding_id = service.organization.email_branding_id if service.organization else None diff --git a/tests/app/test_navigation.py b/tests/app/test_navigation.py index b82ff64db..c7003c431 100644 --- a/tests/app/test_navigation.py +++ b/tests/app/test_navigation.py @@ -87,7 +87,6 @@ EXCLUDED_ENDPOINTS = tuple(map(Navigation.get_endpoint_with_blueprint, { 'email_branding', 'email_branding_govuk', 'email_branding_govuk_and_org', - 'email_branding_nhs', 'email_branding_organization', 'email_branding_request', 'email_branding_something_else',