darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 05:08:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1030 from alphagov/remove-unused-get_all_notificaitons

Browse Source 
Removed unused method
This commit is contained in:
Rebecca Law
2016-11-18 14:55:25 +00:00
committed by GitHub
parent f30495ce92 cebf8e1d65
commit a87129e117
2 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/notify_client/notification_api_client.py
View File

@@ -10,15 +10,6 @@ class NotificationApiClient(BaseAPIClient):
self.service_id = app.config['ADMIN_CLIENT_USER_NAME'] self.service_id = app.config['ADMIN_CLIENT_USER_NAME']
self.api_key = app.config['ADMIN_CLIENT_SECRET'] self.api_key = app.config['ADMIN_CLIENT_SECRET']
def get_all_notifications(self, page=None):
params = {}
if page is not None:
params['page'] = page
return self.get(
url='/notifications',
params=params
)
def get_notifications_for_service( def get_notifications_for_service(
self, self,
service_id, service_id,

14
tests/app/notify_client/test_notification_client.py
View File

@@ -2,20 +2,6 @@ import pytest
from app.notify_client.notification_api_client import NotificationApiClient from app.notify_client.notification_api_client import NotificationApiClient
def test_client_gets_notifications(mocker):
mock_get = mocker.patch('app.notify_client.notification_api_client.NotificationApiClient.get')
NotificationApiClient().get_all_notifications()
mock_get.assert_called_once_with(url='/notifications', params={})
def test_client_gets_notifications_with_page(mocker):
mock_get = mocker.patch('app.notify_client.notification_api_client.NotificationApiClient.get')
NotificationApiClient().get_all_notifications(page=99)
mock_get.assert_called_once_with(url='/notifications', params={'page': 99})
@pytest.mark.parametrize("arguments,expected_call", [ @pytest.mark.parametrize("arguments,expected_call", [
( (
{}, {},