darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 23:38:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace the .column-... classes in _grids.scss

Browse Source 
We had 7 classes in _grids.scss named `.column-...` which were being
used to give a certain column width. These worked by using `@include
grid column()`, which is now deprecated.

`.column-whole` and `.column-three-quarters` can be removed and replaced
with `govuk-grid-column-full` and `govuk-grid-column-three-quarters`
respectively. The other column classes don't have a direct replacment in
GOV.UK Frontend. To get round this, we overwrite the `$govuk-grid-width`
SASS map in `extensions.scss` to add in extra widths, then use this with
the `govuk-grid-column` mixin to create new classes in for our custom
widths in `_grids.scss`
This commit is contained in:
Katie Smith
2020-02-20 16:55:56 +00:00
parent e2952e6a7a
commit a85f7fa2c1
77 changed files with 117 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/main/views/test_letter_branding.py
View File

@@ -32,7 +32,7 @@ def test_letter_branding_page_shows_full_branding_list(
page.select_one('h1').text
) == "Letter branding"
assert page.select('.column-three-quarters a')[-1]['href'] == url_for('main.create_letter_branding')
assert page.select('.govuk-grid-column-three-quarters a')[-1]['href'] == url_for('main.create_letter_branding')
assert brand_names == [
'HM Government',