darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace the .column-... classes in _grids.scss

Browse Source 
We had 7 classes in _grids.scss named `.column-...` which were being
used to give a certain column width. These worked by using `@include
grid column()`, which is now deprecated.

`.column-whole` and `.column-three-quarters` can be removed and replaced
with `govuk-grid-column-full` and `govuk-grid-column-three-quarters`
respectively. The other column classes don't have a direct replacment in
GOV.UK Frontend. To get round this, we overwrite the `$govuk-grid-width`
SASS map in `extensions.scss` to add in extra widths, then use this with
the `govuk-grid-column` mixin to create new classes in for our custom
widths in `_grids.scss`
This commit is contained in:
Katie Smith
2020-02-20 16:55:56 +00:00
parent e2952e6a7a
commit a85f7fa2c1
77 changed files with 117 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/main/views/test_agreement.py
View File

@@ -97,7 +97,7 @@ def test_show_agreement_page(
mocker.patch('app.organisations_client.get_service_organisation', return_value=org)
page = client_request.get('main.service_agreement', service_id=SERVICE_ONE_ID)
links = page.select('main .column-five-sixths a')
links = page.select('main .govuk-grid-column-five-sixths a')
assert len(links) == len(expected_links)
for index, link in enumerate(links):
classes, url = expected_links[index]