darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace the .column-... classes in _grids.scss

Browse Source 
We had 7 classes in _grids.scss named `.column-...` which were being
used to give a certain column width. These worked by using `@include
grid column()`, which is now deprecated.

`.column-whole` and `.column-three-quarters` can be removed and replaced
with `govuk-grid-column-full` and `govuk-grid-column-three-quarters`
respectively. The other column classes don't have a direct replacment in
GOV.UK Frontend. To get round this, we overwrite the `$govuk-grid-width`
SASS map in `extensions.scss` to add in extra widths, then use this with
the `govuk-grid-column` mixin to create new classes in for our custom
widths in `_grids.scss`
This commit is contained in:
Katie Smith
2020-02-20 16:55:56 +00:00
parent e2952e6a7a
commit a85f7fa2c1
77 changed files with 117 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
app/assets/stylesheets/_grids.scss
View File

@@ -1,29 +1,22 @@
.column-whole {
@include grid-column(1/1);
.govuk-grid-column-one-sixth {
@include govuk-grid-column(one-sixth, $class: false);
}
.column-three-quarters {
@include grid-column(3/4);
.govuk-grid-column-five-sixths {
@include govuk-grid-column(five-sixths, $class: false);
}
.column-one-sixth {
@include grid-column(1/6);
.govuk-grid-column-one-eighth {
@include govuk-grid-column(one-eighth, $class: false);
}
.column-five-sixths {
@include grid-column(5/6);
.govuk-grid-column-five-eighths {
@include govuk-grid-column(five-eighths, $class: false);
}
.column-one-eighth {
@include grid-column(1/8);
}
.column-five-eighths {
@include grid-column(5/8);
}
.column-seven-eighths {
@include grid-column(7/8);
.govuk-grid-column-seven-eighths {
@include govuk-grid-column(seven-eighths, $class: false);
}
%top-gutter,