darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 10:53:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make first page of ‘send texts’ use links not form

Browse Source 
This doesn’t need to be a form—it’s not changing any data.

And having the primary action on the page as ‘Use this template’ it makes it
clear what the page is for.
This commit is contained in:
Chris Hill-Scott
2016-02-04 14:02:16 +00:00
parent 7516ec6aba
commit a7d6d85d8b
5 changed files with 19 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/app/main/views/test_sms.py
View File

@@ -23,24 +23,6 @@ def test_choose_sms_template(app_,
assert 'template two content' in content
def test_choose_sms_template_redirects(app_,
api_user_active,
mock_get_user,
mock_get_service_templates,
mock_check_verify_code,
mock_get_service_template):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active)
response = client.post(
url_for('main.choose_sms_template', service_id=12345),
data={'template': '54321'}
)
assert response.status_code == 302
assert response.location == url_for('main.send_sms', service_id=12345, template_id=54321, _external=True)
def test_upload_empty_csvfile_returns_to_upload_page(app_,
api_user_active,
mock_get_user,

3
tests/app/main/views/test_templates.py
View File

@@ -9,7 +9,8 @@ def test_should_return_list_of_all_templates(app_,
mock_get_service_templates,
mock_get_user,
mock_get_user_by_email,
mock_login):
mock_login,
mock_get_jobs):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active)