darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 08:16:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make Google Analytics cookies expire in 1 year

Browse Source
This commit is contained in:
Tom Byers
2020-01-14 14:14:53 +00:00
parent 1d9c5e5da9
commit a67cd65f47
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/analytics/analytics.js
View File

@@ -6,7 +6,7 @@
// Stripped-down wrapper for Google Analytics, based on: // Stripped-down wrapper for Google Analytics, based on:
// https://github.com/alphagov/static/blob/master/doc/analytics.md // https://github.com/alphagov/static/blob/master/doc/analytics.md
const Analytics = function (config) { const Analytics = function (config) {
window.ga('create', config.trackingId, config.cookieDomain); window.ga('create', config.trackingId, config.cookieDomain, config.name, { 'cookieExpires': config.expires * 24 * 60 * 60 });
window.ga('set', 'anonymizeIp', config.anonymizeIp); window.ga('set', 'anonymizeIp', config.anonymizeIp);
window.ga('set', 'displayFeaturesTask', config.displayFeaturesTask); window.ga('set', 'displayFeaturesTask', config.displayFeaturesTask);

4
app/assets/javascripts/analytics/init.js
View File

@@ -25,7 +25,9 @@
cookieDomain: 'auto', cookieDomain: 'auto',
anonymizeIp: true, anonymizeIp: true,
displayFeaturesTask: null, displayFeaturesTask: null,
transport: 'beacon' transport: 'beacon',
name: 'GOVUK.analytics',
expires: 365
}); });
// Track initial pageview // Track initial pageview

6
tests/javascripts/analytics/analytics.test.js
View File

@@ -30,7 +30,9 @@ describe("Analytics", () => {
cookieDomain: 'auto', cookieDomain: 'auto',
anonymizeIp: true, anonymizeIp: true,
displayFeaturesTask: null, displayFeaturesTask: null,
transport: 'beacon' transport: 'beacon',
name: 'GOVUK.analytics',
expires: 365
}); });
}); });
@@ -47,7 +49,7 @@ describe("Analytics", () => {
setUpArguments = window.ga.mock.calls; setUpArguments = window.ga.mock.calls;
expect(setUpArguments[0]).toEqual(['create', 'UA-75215134-1', 'auto']); expect(setUpArguments[0]).toEqual(['create', 'UA-75215134-1', 'auto', 'GOVUK.analytics', { 'cookieExpires': 31536000 }]);
expect(setUpArguments[1]).toEqual(['set', 'anonymizeIp', true]); expect(setUpArguments[1]).toEqual(['set', 'anonymizeIp', true]);
expect(setUpArguments[2]).toEqual(['set', 'displayFeaturesTask', null]); expect(setUpArguments[2]).toEqual(['set', 'displayFeaturesTask', null]);
expect(setUpArguments[3]).toEqual(['set', 'transport', 'beacon']); expect(setUpArguments[3]).toEqual(['set', 'transport', 'beacon']);