darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-16 11:20:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove value of download attribute on links

Browse Source 
We should standardise on <a download> rather than
<a download="download"> everywhere. The value of the download attribute
tells the browser what filename to use, but is overridden by the
Content-Disposition HTTP header. Since it’s not being used, we should
remove it for the sake of disambiguation.
This commit is contained in:
Chris Hill-Scott
2018-01-02 14:38:14 +00:00
parent 85b3978061
commit a604ed60b6
7 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/main/views/test_jobs.py
View File

@@ -97,7 +97,7 @@ def test_should_show_page_for_one_job(
job_id=fake_uuid,
status=status_argument,
)
csv_link = page.find('a', {'download': 'download'})
csv_link = page.select_one('a[download]')
assert csv_link['href'] == url_for(
'main.view_job_csv',
service_id=service_one['id'],