darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-05 16:38:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use new redis key for service templates and broadcasts

Browse Source 
We can drop use of the old key as we no longer need to read data from
the old key. Either data exists in the new key and we read it from there
or data doesn't exist in the new key and we go to the API to get it and
then set it in redis.

Note, the previous commit is important because it means we aren't at
risk of when this commit is being deployed out, of us getting stale data
from the old key.
This commit is contained in:
David McDonald
2020-09-21 16:29:35 +01:00
parent e3baa9ba35
commit a538329d0e
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/notify_client/test_service_api_client.py
View File

@@ -200,7 +200,7 @@ def test_client_returns_count_of_service_templates(
service_api_client.get_service_template,
[SERVICE_ONE_ID, FAKE_TEMPLATE_ID],
[
call('template-{}-version-None'.format(FAKE_TEMPLATE_ID))
call('service-{}-template-{}-version-None'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID))
],
b'{"data_from": "cache"}',
[],
@@ -211,7 +211,7 @@ def test_client_returns_count_of_service_templates(
service_api_client.get_service_template,
[SERVICE_ONE_ID, FAKE_TEMPLATE_ID],
[
call('template-{}-version-None'.format(FAKE_TEMPLATE_ID))
call('service-{}-template-{}-version-None'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID)),
],
None,
[
@@ -219,10 +219,10 @@ def test_client_returns_count_of_service_templates(
],
[
call(
'template-{}-version-None'.format(FAKE_TEMPLATE_ID),
'service-{}-template-{}-version-None'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID),
'{"data_from": "api"}',
ex=604800,
)
),
],
{'data_from': 'api'},
),
@@ -230,7 +230,7 @@ def test_client_returns_count_of_service_templates(
service_api_client.get_service_template,
[SERVICE_ONE_ID, FAKE_TEMPLATE_ID, 1],
[
call('template-{}-version-1'.format(FAKE_TEMPLATE_ID))
call('service-{}-template-{}-version-1'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID))
],
b'{"data_from": "cache"}',
[],
@@ -241,7 +241,7 @@ def test_client_returns_count_of_service_templates(
service_api_client.get_service_template,
[SERVICE_ONE_ID, FAKE_TEMPLATE_ID, 1],
[
call('template-{}-version-1'.format(FAKE_TEMPLATE_ID))
call('service-{}-template-{}-version-1'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID)),
],
None,
[
@@ -249,10 +249,10 @@ def test_client_returns_count_of_service_templates(
],
[
call(
'template-{}-version-1'.format(FAKE_TEMPLATE_ID),
'service-{}-template-{}-version-1'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID),
'{"data_from": "api"}',
ex=604800,
)
),
],
{'data_from': 'api'},
),
@@ -290,7 +290,7 @@ def test_client_returns_count_of_service_templates(
service_api_client.get_service_template_versions,
[SERVICE_ONE_ID, FAKE_TEMPLATE_ID],
[
call('template-{}-versions'.format(FAKE_TEMPLATE_ID))
call('service-{}-template-{}-versions'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID))
],
b'{"data_from": "cache"}',
[],
@@ -301,7 +301,7 @@ def test_client_returns_count_of_service_templates(
service_api_client.get_service_template_versions,
[SERVICE_ONE_ID, FAKE_TEMPLATE_ID],
[
call('template-{}-versions'.format(FAKE_TEMPLATE_ID))
call('service-{}-template-{}-versions'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID)),
],
None,
[
@@ -309,10 +309,10 @@ def test_client_returns_count_of_service_templates(
],
[
call(
'template-{}-versions'.format(FAKE_TEMPLATE_ID),
'service-{}-template-{}-versions'.format(SERVICE_ONE_ID, FAKE_TEMPLATE_ID),
'{"data_from": "api"}',
ex=604800,
)
),
],
{'data_from': 'api'},
),