darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

don't convert letter logo svgs to pngs

Browse Source 
https://github.com/alphagov/notifications-template-preview/pull/371
stops using png logos when rendering png previews of templated letters.

when that is merged we no longer need to convert to pngs when we upload
a new letter logo.
This commit is contained in:
Leo Hemsted
2020-03-02 18:00:26 +00:00
parent 3cfceda0b8
commit a3ccd9660b
4 changed files with 6 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/app/s3_client/test_s3_logo_client.py
View File

@@ -16,7 +16,6 @@ from app.s3_client.s3_logo_client import (
permanent_email_logo_name,
persist_logo,
upload_email_logo,
upload_letter_png_logo,
upload_letter_temp_logo,
)
@@ -76,21 +75,6 @@ def test_upload_letter_temp_logo_calls_correct_args(mocker, fake_uuid, letter_up
assert new_filename == 'letters/static/images/letter-template/temp-{}_test_uuid-test.svg'.format(fake_uuid)
def test_upload_letter_png_logo_calls_correct_args(mocker):
mocked_s3_upload = mocker.patch('app.s3_client.s3_logo_client.utils_s3upload')
mocker.patch.dict('flask.current_app.config', {'LOGO_UPLOAD_BUCKET_NAME': bucket})
upload_letter_png_logo(filename, data, region)
mocked_s3_upload.assert_called_once_with(
filedata=data,
region=region,
bucket_name=bucket,
file_location=filename,
content_type='image/png'
)
def test_persist_logo(client, mocker, fake_uuid, upload_filename):
mocker.patch.dict('flask.current_app.config', {'LOGO_UPLOAD_BUCKET_NAME': bucket})
mocked_get_s3_object = mocker.patch('app.s3_client.s3_logo_client.get_s3_object')