darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename unclear "permissions" attributes

Browse Source 
These are more than a list of permissions: each item includes the
label to use when displaying it as an option on a form. Switching
to a name that reflects how the attributes are used will help to
avoid confusion when we rename some of the other attributes in the
same file in later commits.
This commit is contained in:
Ben Thorner
2021-07-22 14:15:24 +01:00
parent f5580b87dc
commit a38baa0bd8
3 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/main/views/manage_users.py
View File

@@ -30,7 +30,10 @@ from app.main.forms import (
)
from app.models.user import InvitedUser, User
from app.utils.user import is_gov_user, user_has_permissions
from app.utils.user_permissions import broadcast_permissions, permissions
from app.utils.user_permissions import (
broadcast_permission_options,
permission_options,
)
@main.route("/services/<uuid:service_id>/users")
@@ -43,7 +46,7 @@ def manage_users(service_id):
show_search_box=(len(current_service.team_members) > 7),
form=SearchUsersForm(),
permissions=(
broadcast_permissions if current_service.has_permission('broadcast') else permissions
broadcast_permission_options if current_service.has_permission('broadcast') else permission_options
),
)