darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 16:24:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3814 from alphagov/bin-old-upload-document-stuff

Browse Source 
Stop checking for upload_document permission
This commit is contained in:
Katie Smith
2021-02-24 11:01:34 +00:00
committed by GitHub
parent cc06d3bbd8 d7e56f6956
commit a2147e9c84
2 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/templates/views/edit-email-template.html
View File

@@ -36,9 +36,7 @@
{% include "partials/templates/guidance-personalisation.html" %} {% include "partials/templates/guidance-personalisation.html" %}
{% include "partials/templates/guidance-optional-content.html" %} {% include "partials/templates/guidance-optional-content.html" %}
{% include "partials/templates/guidance-links.html" %} {% include "partials/templates/guidance-links.html" %}
{% if current_service.has_permission('upload_document') %} {% include "partials/templates/guidance-send-a-document.html" %}
{% include "partials/templates/guidance-send-a-document.html" %}
{% endif %}
</div> </div>
</div> </div>
{% endcall %} {% endcall %}

15
tests/app/main/views/test_service_settings.py
View File

@@ -4384,21 +4384,6 @@ def test_send_files_by_email_contact_details_does_not_update_invalid_contact_det
assert normalize_spaces(page.h1.text) == "Send files by email" assert normalize_spaces(page.h1.text) == "Send files by email"
def test_contact_link_is_not_displayed_without_the_upload_document_permission(
client_request,
service_one,
mock_get_service_settings_page_common,
no_reply_to_email_addresses,
no_letter_contact_blocks,
single_sms_sender,
):
page = client_request.get(
'main.service_settings',
service_id=SERVICE_ONE_ID,
)
assert 'Contact details' not in page.text
@pytest.mark.parametrize('endpoint, permissions, expected_p', [ @pytest.mark.parametrize('endpoint, permissions, expected_p', [
( (
'main.service_set_inbound_sms', 'main.service_set_inbound_sms',