remove remember_me cookie and related code

tests/__init__.py

@@ -13,7 +13,6 @@ class TestClient(FlaskClient):
         # Skipping authentication here and just log them in
         with self.session_transaction() as session:
             session['user_id'] = user.id
-            session['_fresh'] = True
         if mocker:
             mocker.patch('app.user_api_client.get_user', return_value=user)
             mocker.patch('app.events_api_client.create_event')
@@ -23,9 +22,6 @@ class TestClient(FlaskClient):
             mocker.patch('app.service_api_client.get_service', return_value={'data': service})
         login_user(user, remember=True)
 
-    def login_fresh(self):
-        return True
-
     def logout(self, user):
         self.get(url_for("main.logout"))
 

tests/app/main/views/test_sign_in.py

@@ -144,45 +144,3 @@ def test_should_attempt_redirect_when_user_is_pending(
             'password': 'val1dPassw0rd!'})
     assert response.location == url_for('main.resend_email_verification', _external=True)
     assert response.status_code == 302
-
-
-def test_not_fresh_session_login_redirects_to_dashboard(
-    logged_in_client,
-    api_user_active,
-    mock_login,
-    mock_get_user_by_email,
-    mock_verify_password,
-    mock_get_services_with_one_service,
-):
-    with logged_in_client.session_transaction() as session:
-        assert session['_fresh']
-        session['_fresh'] = False
-    # This should skip the two factor
-    response = logged_in_client.post(
-        url_for('main.sign_in'), data={
-            'email_address': api_user_active.email_address,
-            'password': 'val1dPassw0rd!'})
-    assert response.status_code == 302
-    service_dct = mock_get_services_with_one_service(api_user_active.id)['data'][0]
-    assert response.location == url_for(
-        'main.service_dashboard', service_id=service_dct['id'], _external=True)
-
-
-def test_not_fresh_session_login_redirects_to_choose_service(
-    logged_in_client,
-    api_user_active,
-    mock_login,
-    mock_get_user_by_email,
-    mock_verify_password,
-    mock_get_services,
-):
-    with logged_in_client.session_transaction() as session:
-        assert session['_fresh']
-        session['_fresh'] = False
-    # This should skip the two factor
-    response = logged_in_client.post(
-        url_for('main.sign_in'), data={
-            'email_address': api_user_active.email_address,
-            'password': 'val1dPassw0rd!'})
-    assert response.status_code == 302
-    assert response.location == url_for('main.choose_service', _external=True)

tests/app/main/views/test_two_factor.py

@@ -141,23 +141,6 @@ def test_should_login_user_when_multiple_valid_codes_exist(
     assert response.status_code == 302
 
 
-def test_remember_me_set(
-    client,
-    api_user_active,
-    mock_get_user,
-    mock_get_user_by_email,
-    mock_check_verify_code,
-    mock_get_services_with_one_service,
-):
-    with client.session_transaction() as session:
-        session['user_details'] = {
-            'id': api_user_active.id,
-            'email': api_user_active.email_address}
-    response = client.post(url_for('main.two_factor'),
-                           data={'sms_code': '23456', 'remember_me': True})
-    assert response.status_code == 302
-
-
 def test_two_factor_should_set_password_when_new_password_exists_in_session(
     client,
     api_user_active,

tests/app/test_event_handlers.py

@@ -1,9 +1,6 @@
 from unittest.mock import ANY
 
-from app.event_handlers import (
-    on_user_logged_in,
-    on_user_login_confirmed
-)
+from app.event_handlers import on_user_logged_in
 
 
 def test_on_user_logged_in_calls_events_api(app_, api_user_active, mock_events):
@@ -14,16 +11,3 @@ def test_on_user_logged_in_calls_events_api(app_, api_user_active, mock_events):
                                        {'browser_fingerprint':
                                         {'browser': ANY, 'version': ANY, 'platform': ANY, 'user_agent_string': ''},
                                         'ip_address': ANY, 'user_id': str(api_user_active.id)})
-
-
-def test_on_user_login_confirmed_in_calls_events_api(app_, api_user_active, mock_events):
-
-    with app_.test_request_context():
-        with app_.test_client() as client:
-            client.login(api_user_active)  # user must have been logged in already.
-
-            on_user_login_confirmed(app_)
-            mock_events.assert_called_with('sucessful_login_remember_me',
-                                           {'browser_fingerprint':
-                                            {'browser': ANY, 'version': ANY, 'platform': ANY, 'user_agent_string': ''},
-                                            'ip_address': ANY, 'user_id': str(api_user_active.id)})