darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 09:29:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix test which looks at text of radio buttons

Browse Source 
Looks like `radio_button.text` no longer works. Probably a BeautifulSoup
change. More robust to look at the text of the label and the value of
the input anyway.
This commit is contained in:
Chris Hill-Scott
2017-07-26 10:24:14 +01:00
parent 5ddbe80ea9
commit 9f9c2d5e87
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/app/main/views/test_letters.py
View File

@@ -55,8 +55,14 @@ def test_letters_lets_in_without_permission(
@pytest.mark.parametrize('permissions, choices', [ @pytest.mark.parametrize('permissions, choices', [
(['email', 'sms', 'letter'], ['Email', 'Text message', 'Letter']), (
(['email', 'sms'], ['Email', 'Text message']) ['email', 'sms', 'letter'],
['Email', 'Text message', 'Letter']
),
(
['email', 'sms'],
['Email', 'Text message']
),
]) ])
def test_given_option_to_add_letters_if_allowed( def test_given_option_to_add_letters_if_allowed(
logged_in_client, logged_in_client,
@@ -73,8 +79,13 @@ def test_given_option_to_add_letters_if_allowed(
assert response.status_code == 200 assert response.status_code == 200
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
radios = page.select('input[type=radio]') radios = page.select('input[type=radio]')
labels = page.select('label')
assert len(radios) == len(choices) assert len(radios) == len(choices)
assert len(labels) == len(choices)
for index, choice in enumerate(choices): for index, choice in enumerate(permissions):
assert radios[index].text.strip() == choice assert radios[index]['value'] == choice
for index, label in enumerate(choices):
assert labels[index].text.strip() == label