diff --git a/app/assets/javascripts/listEntry.js b/app/assets/javascripts/listEntry.js index 5f98600e1..15c7405fe 100644 --- a/app/assets/javascripts/listEntry.js +++ b/app/assets/javascripts/listEntry.js @@ -17,6 +17,7 @@ this.minEntries = 2; this.listItemName = this.$wrapper.data('listItemName'); this.getSharedAttributes(); + this.getOriginalClasses(); this.getValues(); this.maxEntries = this.entries.length; @@ -26,30 +27,31 @@ }; ListEntry.optionalAttributes = ['aria-describedby']; ListEntry.prototype.entryTemplate = Hogan.compile( - '
' + - '
diff --git a/app/templates/views/register.html b/app/templates/views/register.html index 09356cbfe..55aef0598 100644 --- a/app/templates/views/register.html +++ b/app/templates/views/register.html @@ -1,6 +1,7 @@ {% extends "base.html" %} {% from "components/page-footer.html" import page_footer %} {% from "components/form.html" import form_wrapper %} +{% from "components/radios.html" import radios %} {% block per_page_title %} Create an account @@ -26,7 +27,7 @@ Create an account }) }} {{ form.password(param_extensions={"hint": {"text": "At least 8 characters"}, "autocomplete": "new-password"}) }} - {{form.auth_type}} + {{ radios(form.auth_type) }} {{ page_footer("Continue") }} {% endcall %} diff --git a/app/templates/views/service-settings/data-retention/add.html b/app/templates/views/service-settings/data-retention/add.html index bd20e5f7e..3c9499d69 100644 --- a/app/templates/views/service-settings/data-retention/add.html +++ b/app/templates/views/service-settings/data-retention/add.html @@ -3,6 +3,7 @@ {% from "components/page-footer.html" import page_footer %} {% from "components/form.html" import form_wrapper %} {% from "components/components/back-link/macro.njk" import usaBackLink %} +{% from "components/radios.html" import radios %} {% block service_page_title %} Set data retention @@ -16,7 +17,9 @@ {{ page_header('Set data retention') }} {% call form_wrapper() %} - {{ form.notification_type }} +
+ {{ radios(form.notification_type) }} +
{{ form.days_of_retention }} {{ page_footer('Add') }} {% endcall %} diff --git a/app/templates/views/service-settings/link-service-to-organization.html b/app/templates/views/service-settings/link-service-to-organization.html index 222c3951f..8d847a333 100644 --- a/app/templates/views/service-settings/link-service-to-organization.html +++ b/app/templates/views/service-settings/link-service-to-organization.html @@ -4,6 +4,7 @@ {% from "components/live-search.html" import live_search %} {% from "components/form.html" import form_wrapper %} {% from "components/components/back-link/macro.njk" import usaBackLink %} +{% from "components/radios.html" import radios %} {% set page_title = "Link service to organization" %} @@ -26,7 +27,9 @@ ) }} {% call form_wrapper(data_force_focus=True) %} {% if has_organizations %} - {{ form.organizations }} +
+ {{ radios(form.organizations) }} +
{{ sticky_page_footer('Save') }} {% else %}

No organizations

diff --git a/app/templates/views/set-up-your-profile.html b/app/templates/views/set-up-your-profile.html index e131aff2f..9a0e11cfc 100644 --- a/app/templates/views/set-up-your-profile.html +++ b/app/templates/views/set-up-your-profile.html @@ -2,6 +2,7 @@ {% from "components/page-footer.html" import page_footer %} {% from "components/form.html" import form_wrapper %} {% from "components/components/select/macro.njk" import usaSelect -%} +{% from "components/radios.html" import radios %} {% block per_page_title %} Set up your profile @@ -68,7 +69,7 @@ Set up your profile ] }) }}--> - {{form.auth_type}} + {{ radios(form.auth_type) }} {{ page_footer("Save") }} {% endcall %} diff --git a/app/templates/views/templates/_template_list.html b/app/templates/views/templates/_template_list.html index 6fc0baeec..e29131473 100644 --- a/app/templates/views/templates/_template_list.html +++ b/app/templates/views/templates/_template_list.html @@ -1,3 +1,5 @@ +{% from "components/checkboxes.html" import checkboxes %} + {% macro format_item_name(name, separators=True) -%} {%- if name is string -%} {{- name -}} diff --git a/app/templates/views/templates/set-sender.html b/app/templates/views/templates/set-sender.html index 2bb9a4162..5995343fe 100644 --- a/app/templates/views/templates/set-sender.html +++ b/app/templates/views/templates/set-sender.html @@ -2,6 +2,7 @@ {% from "components/page-footer.html" import page_footer %} {% from "components/form.html" import form_wrapper %} {% from "components/components/back-link/macro.njk" import usaBackLink %} +{% from "components/radios.html" import radios %} {% block service_page_title %} {{ sender_context.title }} @@ -15,15 +16,7 @@
{% call form_wrapper() %} - {{ form.sender(param_extensions={ - 'fieldset': { - 'legend': { - 'isPageHeading': True, - 'text': sender_context.title - } - }, - 'classes': 'grid-col-9' - }) }} + {{ radios(form.sender) }}
{{ page_footer('Continue') }}
diff --git a/app/templates/views/templates/set-template-sender.html b/app/templates/views/templates/set-template-sender.html index 289ff222f..9936b851c 100644 --- a/app/templates/views/templates/set-template-sender.html +++ b/app/templates/views/templates/set-template-sender.html @@ -2,6 +2,7 @@ {% from "components/page-footer.html" import page_footer %} {% from "components/form.html" import form_wrapper %} {% from "components/components/back-link/macro.njk" import usaBackLink %} +{% from "components/radios.html" import radios %} {% set page_title = 'Set letter contact block' %} @@ -17,18 +18,9 @@
{% call form_wrapper() %} - {{ form.sender(param_extensions={ - 'fieldset': { - 'legend': { - 'isPageHeading': True, - 'text': page_title - } - }, - 'classes': 'grid-col-9' - }) }} + {{ radios(form.sender) }}
{{ page_footer('Continue') }} - Add new sender
{% endcall %}
diff --git a/backstop_data/bitmaps_reference/backstop_test_API_Guest_List_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_API_Guest_List_0_document_0_desktop.png new file mode 100644 index 000000000..baa9e2d02 Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_API_Guest_List_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_API_Keys_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_API_Keys_0_document_0_desktop.png index 262db6187..2f7e74d6c 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_API_Keys_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_API_Keys_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_API_Keys_Create_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_API_Keys_Create_0_document_0_desktop.png index 1710a11c7..00125b5b6 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_API_Keys_Create_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_API_Keys_Create_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_About_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_About_0_document_0_desktop.png index 75d6870af..d514c2f0f 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_About_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_About_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Change_User_Auth_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Change_User_Auth_0_document_0_desktop.png index b2e7c30fc..bb470a095 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Change_User_Auth_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Change_User_Auth_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Choose_Service_-_Accounts_1_ausa-buttonhrefadd-service_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Choose_Service_-_Accounts_1_ausa-buttonhrefadd-service_0_desktop.png index df8b6ccc3..a3a1a2b03 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Choose_Service_-_Accounts_1_ausa-buttonhrefadd-service_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Choose_Service_-_Accounts_1_ausa-buttonhrefadd-service_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Choose_Template_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Choose_Template_0_document_0_desktop.png index ed36e8bc1..16477aaf9 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Choose_Template_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Choose_Template_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Data_Retention_Add_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Data_Retention_Add_0_document_0_desktop.png new file mode 100644 index 000000000..f8dea36d1 Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_Data_Retention_Add_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Email_Not_Received_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Email_Not_Received_0_document_0_desktop.png index 4ea571447..6f873ed87 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Email_Not_Received_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Email_Not_Received_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Invite_User_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Invite_User_0_document_0_desktop.png index 2c427b325..7107461be 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Invite_User_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Invite_User_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Link_Service_to_Organization_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Link_Service_to_Organization_0_document_0_desktop.png new file mode 100644 index 000000000..b0fdfd898 Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_Link_Service_to_Organization_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Notifygov_Sign_In_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Notifygov_Sign_In_0_document_0_desktop.png index 4ea571447..6f873ed87 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Notifygov_Sign_In_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Notifygov_Sign_In_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Performance_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Performance_0_document_0_desktop.png index 2491d61d8..3b2a0db92 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Performance_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Performance_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_Live_Services_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_Live_Services_0_document_0_desktop.png index 4de5b957e..e96632104 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_Live_Services_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_Live_Services_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_User_Auth_Type_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_User_Auth_Type_0_document_0_desktop.png new file mode 100644 index 000000000..bb470a095 Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_Platform_Admin_User_Auth_Type_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_SMS_Template_Preview_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_SMS_Template_Preview_0_document_0_desktop.png index f36e2d62c..eca353619 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_SMS_Template_Preview_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_SMS_Template_Preview_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Send_One_Off_Step_2_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Send_One_Off_Step_2_0_document_0_desktop.png index f36e2d62c..eca353619 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Send_One_Off_Step_2_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Send_One_Off_Step_2_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Service_SMS_Prefix_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Service_SMS_Prefix_0_document_0_desktop.png index ccf200f46..53e79ee6d 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Service_SMS_Prefix_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Service_SMS_Prefix_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Service_Send_Files_By_Email_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Service_Send_Files_By_Email_0_document_0_desktop.png index a1e7939ae..91b6f083f 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Service_Send_Files_By_Email_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Service_Send_Files_By_Email_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Service_Settings_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Service_Settings_0_document_0_desktop.png index 81a6f823a..c298dd2fa 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Service_Settings_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Service_Settings_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Set_Template_Letter_Sender_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Set_Template_Letter_Sender_0_document_0_desktop.png new file mode 100644 index 000000000..51af137ab Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_Set_Template_Letter_Sender_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Set_Template_Sender_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Set_Template_Sender_0_document_0_desktop.png new file mode 100644 index 000000000..db45f0738 Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_Set_Template_Sender_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Team_Members_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Team_Members_0_document_0_desktop.png index 65094dfbf..76fe8a299 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Team_Members_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Team_Members_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Text_Not_Received_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Text_Not_Received_0_document_0_desktop.png index 4ea571447..6f873ed87 100644 Binary files a/backstop_data/bitmaps_reference/backstop_test_Text_Not_Received_0_document_0_desktop.png and b/backstop_data/bitmaps_reference/backstop_test_Text_Not_Received_0_document_0_desktop.png differ diff --git a/backstop_data/bitmaps_reference/backstop_test_Uploads_0_document_0_desktop.png b/backstop_data/bitmaps_reference/backstop_test_Uploads_0_document_0_desktop.png new file mode 100644 index 000000000..a2e89fa15 Binary files /dev/null and b/backstop_data/bitmaps_reference/backstop_test_Uploads_0_document_0_desktop.png differ diff --git a/tests/javascripts/listEntry.test.js b/tests/javascripts/listEntry.test.js index 99357a65c..d2409d03b 100644 --- a/tests/javascripts/listEntry.test.js +++ b/tests/javascripts/listEntry.test.js @@ -50,10 +50,10 @@ describe("List entry", () => { result += `
-
`; } @@ -249,7 +249,7 @@ describe("List entry", () => { triggerEvent(inputList.querySelectorAll('.input-list__button--remove')[0], 'click'); const newNums = Array.from( - inputList.querySelectorAll('.govuk-input--numbered__label') + inputList.querySelectorAll('.usa-label') ) .map((itemNum, idx) => { return parseInt(itemNum.lastChild.nodeValue, 10); diff --git a/urls.js b/urls.js index 5b4d7021e..c53398bb9 100644 --- a/urls.js +++ b/urls.js @@ -14,22 +14,26 @@ const routes = { { label: 'Email Not Received', path: '/email-not-received' }, { label: 'Text Not Received', path: '/text-not-received' }, { label: 'Performance', path: '/performance' }, + // Registration pages with radio buttons + // Note: /register returns 404, registration is handled through login.gov + // { label: 'Register', path: '/register' }, + // { label: 'Register From Invite', path: '/register/from-invite/example-token' }, ], authenticated: [ { label: 'SMS Template Preview', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/send/a4e530e7-cae2-4e24-a1e9-752141a0b58e/one-off/step-0', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/send/9c2b7a55-8785-4dc6-84d6-eb0e0615590d/one-off/step-0', }, // Pages with govuk buttons that need testing { label: 'API Keys', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/api/keys', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/api/keys', }, // Pages to test radio buttons before converting govukRadios to USWDS { label: 'API Keys Create', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/api/keys/create', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/api/keys/create', }, { label: 'Change User Auth', @@ -41,42 +45,76 @@ const routes = { }, { label: 'Service Settings', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/service-settings', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/service-settings', }, { label: 'Service Send Files By Email', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/service-settings/send-files-by-email', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/service-settings/send-files-by-email', }, { label: 'Service SMS Prefix', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/service-settings/sms-prefix', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/service-settings/sms-prefix', }, { label: 'Send One Off Step 2', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/send/a4e530e7-cae2-4e24-a1e9-752141a0b58e/one-off/step-2', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/send/9c2b7a55-8785-4dc6-84d6-eb0e0615590d/one-off/step-2', }, { label: 'Choose Template', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/templates', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/templates', }, { label: 'Team Members', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/users', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/users', }, { label: 'Invite User', - path: '/services/e6de050d-bd56-4f49-b44b-cb789c4f79fd/users/invite', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/users/invite', }, - // Platform admin pages with checkboxes { label: 'Platform Admin Live Services', path: '/platform-admin/live-services', }, - // Organization pages { label: 'Add Organization', path: '/organizations/add', }, + { + label: 'Uploads', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/uploads', + }, + { + label: 'API Guest List', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/api/guest-list', + }, + // User profile and auth pages with radio buttons + // Note: /set-up-your-profile requires special auth flow from login.gov + // { + // label: 'Set Up Your Profile', + // path: '/set-up-your-profile', + // }, + { + label: 'Platform Admin User Auth Type', + path: '/users/6af522d0-2915-4e52-83a3-3690455a5fe6/change_auth', + }, + // Service settings pages with radio buttons + { + label: 'Data Retention Add', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/data-retention/add', + }, + { + label: 'Link Service to Organization', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/service-settings/link-service-to-organization', + }, + // Template sender pages with radio buttons + { + label: 'Set Template Sender', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/send/9c2b7a55-8785-4dc6-84d6-eb0e0615590d/set-sender', + }, + { + label: 'Set Template Letter Sender', + path: '/services/829ac564-59e9-47c5-ad69-e91315641c31/templates/9c2b7a55-8785-4dc6-84d6-eb0e0615590d/set-template-sender', + }, ], // Using Notify section