From f647b09ac226e112e49dd39e8698135791b5d411 Mon Sep 17 00:00:00 2001 From: Alex Janousek Date: Tue, 7 Oct 2025 12:29:08 -0400 Subject: [PATCH] Updates for govuk pr followup --- .gitignore | 3 + .../preventDuplicateFormSubmissions.js | 4 -- app/main/views/pricing.py | 9 --- app/navigation.py | 3 - app/templates/views/pricing/how-to-pay.html | 64 ------------------- gulpfile.js | 3 +- tests/app/main/views/test_index.py | 1 - tests/app/test_navigation.py | 1 - urls.js | 1 - 9 files changed, 4 insertions(+), 85 deletions(-) delete mode 100644 app/templates/views/pricing/how-to-pay.html diff --git a/.gitignore b/.gitignore index d223fcc17..23804285f 100644 --- a/.gitignore +++ b/.gitignore @@ -151,3 +151,6 @@ playwright/ backstop_data/bitmaps_test/ backstop_data/html_report/ backstop_data/engine_scripts/playwright/ + +# Pa11y +pa11y-results.txt diff --git a/app/assets/javascripts/preventDuplicateFormSubmissions.js b/app/assets/javascripts/preventDuplicateFormSubmissions.js index 540d1fc6b..c18a99c37 100644 --- a/app/assets/javascripts/preventDuplicateFormSubmissions.js +++ b/app/assets/javascripts/preventDuplicateFormSubmissions.js @@ -30,10 +30,6 @@ }); $cancelButton.prop('disabled', true); }, 50); // Small delay to ensure form submits first - - setTimeout(() => { - renableSubmitButton($submitButton)(); - }, 10000); // fallback safety } else { setTimeout(() => renableSubmitButton($submitButton)(), 1500); } diff --git a/app/main/views/pricing.py b/app/main/views/pricing.py index f9fc0dc4c..596953452 100644 --- a/app/main/views/pricing.py +++ b/app/main/views/pricing.py @@ -25,12 +25,3 @@ def pricing(): search_form=SearchByNameForm(), navigation_links=using_notify_nav(), ) - - -@main.route("/pricing/how-to-pay") -@user_is_logged_in -def how_to_pay(): - return render_template( - "views/pricing/how-to-pay.html", - navigation_links=using_notify_nav(), - ) diff --git a/app/navigation.py b/app/navigation.py index daa29d90a..a539671c8 100644 --- a/app/navigation.py +++ b/app/navigation.py @@ -90,9 +90,6 @@ class HeaderNavigation(Navigation): "view_jobs", "usage", }, - "pricing": { - "how_to_pay", - }, "documentation": { "documentation", "integration_testing", diff --git a/app/templates/views/pricing/how-to-pay.html b/app/templates/views/pricing/how-to-pay.html deleted file mode 100644 index 7a9df90e0..000000000 --- a/app/templates/views/pricing/how-to-pay.html +++ /dev/null @@ -1,64 +0,0 @@ -{% extends "base.html" %} -{% from "components/page-header.html" import page_header %} - -{% block per_page_title %} - How to pay -{% endblock %} - -{% block content_column_content %} - - {{ page_header('How to pay') }} - - - -{% endblock %} diff --git a/gulpfile.js b/gulpfile.js index e4a4a079f..9fd60d1f7 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -7,7 +7,6 @@ plugins.addSrc = require('gulp-add-src'); plugins.babel = require('gulp-babel'); plugins.cleanCSS = require('gulp-clean-css'); plugins.concat = require('gulp-concat'); -plugins.jshint = require('gulp-jshint'); plugins.prettyerror = require('gulp-prettyerror'); plugins.uglify = require('gulp-uglify'); @@ -149,7 +148,7 @@ const styles = async () => { await uswds.compileSass(); }; -// Task to copy USWDS assetsconst +// Task to copy USWDS assets const copyUSWDSAssets = () => { return src([ 'node_modules/@uswds/uswds/dist/img/**/*', diff --git a/tests/app/main/views/test_index.py b/tests/app/main/views/test_index.py index 806ad6486..08527924e 100644 --- a/tests/app/main/views/test_index.py +++ b/tests/app/main/views/test_index.py @@ -98,7 +98,6 @@ def test_hiding_pages_from_search_engines( "multiple_languages", "benchmark_performance", "message_status", - "how_to_pay", "get_started", "how_to", "create_and_send_messages", diff --git a/tests/app/test_navigation.py b/tests/app/test_navigation.py index 24b2717d6..e7c4646bb 100644 --- a/tests/app/test_navigation.py +++ b/tests/app/test_navigation.py @@ -112,7 +112,6 @@ EXCLUDED_ENDPOINTS = tuple( "guest_list", "how_to", "history", - "how_to_pay", "inbound_sms_admin", "index", "information_risk_management", diff --git a/urls.js b/urls.js index a88764d6a..5c9772d69 100644 --- a/urls.js +++ b/urls.js @@ -118,7 +118,6 @@ const routes = { documentation: [ { label: 'Documentation', path: '/documentation' }, - { label: 'Pricing How to Pay', path: '/pricing/how-to-pay' }, { label: 'Create Messages', path: '/using-notify/how-to/create-and-send-messages' }, { label: 'Edit Messages', path: '/using-notify/how-to/edit-and-format-messages' }, { label: 'Send Files by Email', path: '/using-notify/how-to/send-files-by-email' },