mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-08 08:28:15 -04:00
Edit mobile number page
This commit is contained in:
@@ -22,6 +22,7 @@ from app.main.forms import (
|
|||||||
InviteUserForm,
|
InviteUserForm,
|
||||||
PermissionsForm,
|
PermissionsForm,
|
||||||
SearchUsersForm,
|
SearchUsersForm,
|
||||||
|
ChangeMobileNumberForm
|
||||||
)
|
)
|
||||||
from app.models.user import permissions
|
from app.models.user import permissions
|
||||||
from app.utils import redact_mobile_number, user_has_permissions
|
from app.utils import redact_mobile_number, user_has_permissions
|
||||||
@@ -203,11 +204,21 @@ def confirm_edit_user_email(service_id, user_id):
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
@main.route("/services/<service_id>/users/<user_id>/edit-phone-number", methods=['GET', 'POST'])
|
@main.route("/services/<service_id>/users/<user_id>/edit-mobile-number", methods=['GET', 'POST'])
|
||||||
@login_required
|
@login_required
|
||||||
@user_has_permissions('manage_service')
|
@user_has_permissions('manage_service')
|
||||||
def edit_user_phone_number(service_id, user_id):
|
def edit_user_mobile_number(service_id, user_id):
|
||||||
return True
|
user = user_api_client.get_user(user_id)
|
||||||
|
user_mobile_number = redact_mobile_number(user.mobile_number)
|
||||||
|
|
||||||
|
form = ChangeMobileNumberForm(mobile_number=user_mobile_number)
|
||||||
|
|
||||||
|
return render_template(
|
||||||
|
'views/manage-users/edit-user-mobile.html',
|
||||||
|
user=user,
|
||||||
|
form=form,
|
||||||
|
service_id=service_id
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
@main.route("/services/<service_id>/cancel-invited-user/<uuid:invited_user_id>", methods=['GET'])
|
@main.route("/services/<service_id>/cancel-invited-user/<uuid:invited_user_id>", methods=['GET'])
|
||||||
|
|||||||
@@ -17,8 +17,8 @@
|
|||||||
{{ user.email_address }} <a href="{{ url_for('.edit_user_email', service_id=current_service.id, user_id=user.id)}}">Change</a>
|
{{ user.email_address }} <a href="{{ url_for('.edit_user_email', service_id=current_service.id, user_id=user.id)}}">Change</a>
|
||||||
</p>
|
</p>
|
||||||
{% if mobile_number %}
|
{% if mobile_number %}
|
||||||
<p id="user_phone_number">
|
<p id="user_mobile_number">
|
||||||
{{ mobile_number }} <a href="{{ url_for('.edit_user_phone_number', service_id=current_service.id, user_id=user.id)}}">Change</a>
|
{{ mobile_number }} <a href="{{ url_for('.edit_user_mobile_number', service_id=current_service.id, user_id=user.id)}}">Change</a>
|
||||||
</p>
|
</p>
|
||||||
{% endif %}
|
{% endif %}
|
||||||
<div class="grid-row">
|
<div class="grid-row">
|
||||||
|
|||||||
@@ -1011,7 +1011,7 @@ def test_confirm_edit_user_email_with_no_permission_aborts():
|
|||||||
pass
|
pass
|
||||||
|
|
||||||
|
|
||||||
def test_edit_user_permissions_page_displays_redacted_phone_number_and_change_link(
|
def test_edit_user_permissions_page_displays_redacted_mobile_number_and_change_link(
|
||||||
client_request,
|
client_request,
|
||||||
active_user_with_permissions,
|
active_user_with_permissions,
|
||||||
service_one,
|
service_one,
|
||||||
@@ -1027,29 +1027,46 @@ def test_edit_user_permissions_page_displays_redacted_phone_number_and_change_li
|
|||||||
)
|
)
|
||||||
|
|
||||||
assert user.name in page.find('h1').text
|
assert user.name in page.find('h1').text
|
||||||
phone_number_paragraph = page.select('p[id=user_phone_number]')[0]
|
mobile_number_paragraph = page.select('p[id=user_mobile_number]')[0]
|
||||||
assert '0770****762' in phone_number_paragraph.text
|
assert '0770****762' in mobile_number_paragraph.text
|
||||||
change_link = phone_number_paragraph.findChild()
|
change_link = mobile_number_paragraph.findChild()
|
||||||
assert change_link.attrs['href'] == '/services/{}/users/{}/edit-phone-number'.format(
|
assert change_link.attrs['href'] == '/services/{}/users/{}/edit-mobile-number'.format(
|
||||||
service_one['id'], user.id
|
service_one['id'], user.id
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
def test_edit_user_phone_number_page():
|
def test_edit_user_mobile_number_page(
|
||||||
|
client_request,
|
||||||
|
active_user_with_permissions,
|
||||||
|
service_one,
|
||||||
|
mocker
|
||||||
|
):
|
||||||
|
user = active_user_with_permissions
|
||||||
|
mocker.patch('app.user_api_client.get_user', return_value=user)
|
||||||
|
|
||||||
|
page = client_request.get(
|
||||||
|
'main.edit_user_mobile_number',
|
||||||
|
service_id=service_one['id'],
|
||||||
|
user_id=user.id
|
||||||
|
)
|
||||||
|
|
||||||
|
assert page.find('h1').text == "Change team member’s mobile number"
|
||||||
|
assert page.select('p[id=user_name]')[0].text == "This will change the mobile number for {}.".format(user.name)
|
||||||
|
assert page.select('input[name=mobile_number]')[0].attrs["value"] == "0770****762"
|
||||||
|
assert page.select('button[type=submit]')[0].text == "Save"
|
||||||
|
|
||||||
|
|
||||||
|
def test_edit_user_mobile_number_redirects_to_confirmation():
|
||||||
pass
|
pass
|
||||||
|
|
||||||
|
|
||||||
def test_edit_user_phone_number_redirects_to_confirmation():
|
def test_confirm_edit_user_mobile_number_page():
|
||||||
pass
|
pass
|
||||||
|
|
||||||
|
|
||||||
def test_confirm_edit_user_phone_number_page():
|
def test_confirm_edit_user_mobile_number_changes_user_mobile_number():
|
||||||
pass
|
pass
|
||||||
|
|
||||||
|
|
||||||
def test_confirm_edit_user_phone_number_changes_user_mobile_number():
|
def test_confirm_edit_user_mobile_number_with_no_permission_aborts():
|
||||||
pass
|
|
||||||
|
|
||||||
|
|
||||||
def test_confirm_edit_user_phone_number_with_no_permission_aborts():
|
|
||||||
pass
|
pass
|
||||||
|
|||||||
Reference in New Issue
Block a user