darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 05:59:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix duplicated H1 on ‘New letter branding’ page

Browse Source 
For accessibility reasons a page should have one (and only one) H1. This
commit fixes an instance where the H1 was duplicated as a result of the
work done to componentize our page headings.

It also adds an extra check to `client_request` so that we don’t
introduce pages with multiple or no H1s in the future.
This commit is contained in:
Chris Hill-Scott
2019-05-21 15:44:27 +01:00
parent b1df698cf7
commit 9d1a7904a8
5 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/app/main/views/test_send.py
View File

@@ -998,7 +998,7 @@ def test_send_test_step_redirects_if_session_not_setup(
):
mocker.patch('app.user_api_client.get_user', return_value=user(fake_uuid))
template_mock(mocker)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=9)
with client_request.session_transaction() as session:
assert 'recipient' not in session
@@ -1109,7 +1109,7 @@ def test_send_one_off_or_test_has_correct_page_titles(
):
mocker.patch('app.user_api_client.get_user', return_value=user(fake_uuid))
template_mock(mocker)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=9)
response = logged_in_client.get(
partial_url(service_id=service_one['id'], template_id=fake_uuid, step_index=0),
@@ -1224,7 +1224,7 @@ def test_send_one_off_has_skip_link(
):
mocker.patch('app.user_api_client.get_user', return_value=user(fake_uuid))
template_mock(mocker)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=9)
page = client_request.get(
'main.send_one_off_step',
@@ -1261,7 +1261,7 @@ def test_send_one_off_has_sticky_header_for_email_and_letter(
expected_sticky,
):
template_mock(mocker)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=9)
page = client_request.get(
'main.send_one_off_step',
@@ -1774,7 +1774,7 @@ def test_send_test_caches_page_count(
fake_uuid,
):
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=99)
mocker.patch('app.main.views.send.get_page_count_for_letter', return_value=9)
logged_in_client.get(
url_for(
@@ -1785,7 +1785,7 @@ def test_send_test_caches_page_count(
follow_redirects=True,
)
with logged_in_client.session_transaction() as session:
assert session['send_test_letter_page_count'] == 99
assert session['send_test_letter_page_count'] == 9
def test_send_test_indicates_optional_address_columns(