diff --git a/app/main/views/add_service.py b/app/main/views/add_service.py
index 3a6d7722f..e8610f822 100644
--- a/app/main/views/add_service.py
+++ b/app/main/views/add_service.py
@@ -42,8 +42,8 @@ def add_service():
restricted=True,
user_id=session['user_id'],
email_from=email_from)
-
- return redirect(url_for('main.tour', service_id=service_id, page=1))
+ session['service_id'] = service_id
+ return redirect(url_for('main.tour', page=1))
else:
return render_template(
'views/add-service.html',
diff --git a/app/main/views/dashboard.py b/app/main/views/dashboard.py
index 81d1caeed..df5076e82 100644
--- a/app/main/views/dashboard.py
+++ b/app/main/views/dashboard.py
@@ -34,7 +34,8 @@ def service_dashboard(service_id):
if session.get('invited_user'):
session.pop('invited_user', None)
- return redirect(url_for("main.tour", service_id=service_id, page=1))
+ session['service_id'] = service_id
+ return redirect(url_for("main.tour", page=1))
statistics = statistics_api_client.get_statistics_for_service(service_id)['data']
template_statistics = aggregate_usage(template_statistics_client.get_template_statistics_for_service(service_id))
diff --git a/app/main/views/tour.py b/app/main/views/tour.py
index a1a98300f..3ab1756df 100644
--- a/app/main/views/tour.py
+++ b/app/main/views/tour.py
@@ -12,9 +12,8 @@ headings = [
]
-@main.route("/services//tour/")
-@login_required
-def tour(service_id, page):
+@main.route("/tour/")
+def tour(page):
return render_template(
'views/tour/{}.html'.format(page),
current_page=page,
diff --git a/app/templates/admin_template.html b/app/templates/admin_template.html
index 168525842..1bf1be45b 100644
--- a/app/templates/admin_template.html
+++ b/app/templates/admin_template.html
@@ -91,8 +91,11 @@
diff --git a/app/templates/views/tour/1.html b/app/templates/views/tour/1.html
index 2c3df7ad3..1474c8825 100644
--- a/app/templates/views/tour/1.html
+++ b/app/templates/views/tour/1.html
@@ -17,7 +17,7 @@
We can remove these restrictions when you’re ready.
-
+
Next
{% endcall %}
diff --git a/app/templates/views/tour/2.html b/app/templates/views/tour/2.html
index d8508538a..fd321e927 100644
--- a/app/templates/views/tour/2.html
+++ b/app/templates/views/tour/2.html
@@ -29,7 +29,7 @@
>
-
+
Next
{% endcall %}
diff --git a/app/templates/views/tour/3.html b/app/templates/views/tour/3.html
index 4bcd6a4da..c6138148b 100644
--- a/app/templates/views/tour/3.html
+++ b/app/templates/views/tour/3.html
@@ -32,7 +32,7 @@
Developers, you can add data automatically using an API
-
+
Next
{% endcall %}
diff --git a/app/templates/views/tour/4.html b/app/templates/views/tour/4.html
index e976214e8..2b845d0fa 100644
--- a/app/templates/views/tour/4.html
+++ b/app/templates/views/tour/4.html
@@ -14,7 +14,7 @@
Notify merges your data with the template and sends the messages
-
+
Next
diff --git a/tests/app/main/views/test_accept_invite.py b/tests/app/main/views/test_accept_invite.py
index 7cfbd8142..740888484 100644
--- a/tests/app/main/views/test_accept_invite.py
+++ b/tests/app/main/views/test_accept_invite.py
@@ -1,4 +1,4 @@
-from flask import url_for
+from flask import url_for, session
from bs4 import BeautifulSoup
@@ -372,8 +372,8 @@ def test_new_invited_user_verifies_and_added_to_service(app_,
mock_add_user_to_service.assert_called_with(data['service'], new_user_id, expected_permissions)
mock_accept_invite.assert_called_with(data['service'], sample_invite['id'])
mock_check_verify_code.assert_called_once_with(new_user_id, '12345', 'sms')
+ assert service_one['id'] == session['service_id']
raw_html = response.data.decode('utf-8')
page = BeautifulSoup(raw_html, 'html.parser')
element = page.find('h2').text == 'Trial mode'
- assert service_one['id'] in raw_html
diff --git a/tests/app/main/views/test_add_service.py b/tests/app/main/views/test_add_service.py
index 4162282fc..bb6eb3f76 100644
--- a/tests/app/main/views/test_add_service.py
+++ b/tests/app/main/views/test_add_service.py
@@ -1,4 +1,4 @@
-from flask import url_for
+from flask import url_for, session
import app
@@ -25,15 +25,18 @@ def test_should_add_service_and_redirect_to_next_page(app_,
response = client.post(
url_for('main.add_service'),
data={'name': 'testing the post'})
- assert response.status_code == 302
- assert response.location == url_for('main.tour', service_id=101, page=1, _external=True)
assert mock_get_services.called
- mock_create_service.asset_called_once_with(service_name='testing the post',
- active=False,
- limit=app_.config['DEFAULT_SERVICE_LIMIT'],
- restricted=True,
- user_id=api_user_active.id,
- email_from='testing.the.post')
+ mock_create_service.assert_called_once_with(
+ service_name='testing the post',
+ active=False,
+ message_limit=app_.config['DEFAULT_SERVICE_LIMIT'],
+ restricted=True,
+ user_id=api_user_active.id,
+ email_from='testing.the.post'
+ )
+ assert session['service_id'] == 101
+ assert response.status_code == 302
+ assert response.location == url_for('main.tour', page=1, _external=True)
def test_should_return_form_errors_when_service_name_is_empty(app_,
diff --git a/tests/app/main/views/test_tour.py b/tests/app/main/views/test_tour.py
index 0b2249eeb..1ab05ade8 100644
--- a/tests/app/main/views/test_tour.py
+++ b/tests/app/main/views/test_tour.py
@@ -14,7 +14,6 @@ def test_should_render_tour_pages(
):
with app_.test_request_context():
with app_.test_client() as client:
- client.login(api_user_active, mocker)
- response = client.get(url_for('main.tour', service_id=101, page=page))
+ response = client.get(url_for('main.tour', page=page))
assert response.status_code == 200
assert 'Next' in response.get_data(as_text=True)