darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-03 21:21:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make technical failure letters show up on the activity page

Browse Source
This commit is contained in:
Chris Hill-Scott
2019-01-10 17:23:03 +00:00
parent 55279c91b5
commit 989875294b
3 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/__init__.py
View File

@@ -362,18 +362,20 @@ def format_notification_status(status, template_type):
'sent': 'Sent internationally' 'sent': 'Sent internationally'
}, },
'letter': { 'letter': {
'failed': 'Failed', 'failed': '',
'technical-failure': 'Technical failure', 'technical-failure': 'Technical failure',
'temporary-failure': 'Temporary failure', 'temporary-failure': '',
'permanent-failure': 'Permanent failure', 'permanent-failure': 'Cancelled',
'delivered': 'Delivered', 'delivered': '',
'sending': 'Sending', 'received': '',
'created': 'Sending', 'accepted': '',
'sent': 'Delivered', 'sending': '',
'pending-virus-check': 'Pending virus check', 'created': '',
'sent': '',
'pending-virus-check': '',
'virus-scan-failed': 'Virus detected', 'virus-scan-failed': 'Virus detected',
'returned-letter': 'Delivered', 'returned-letter': '',
'cancelled': 'Cancelled,', 'cancelled': '',
'validation-failed': 'Validation failed', 'validation-failed': 'Validation failed',
} }
}[template_type].get(status, status) }[template_type].get(status, status)

11
app/templates/components/table.html
View File

@@ -144,7 +144,7 @@
{% macro notification_status_field(notification) %} {% macro notification_status_field(notification) %}
{% set displayed_on_single_line = notification.status in ['created', 'pending', 'sending', 'delivered'] %} {% set displayed_on_single_line = notification.status in ['created', 'pending', 'pending-virus-check', 'sending', 'sent', 'delivered', 'returned-letter', 'accepted', 'received'] %}
{% if not notification %} {% if not notification %}
{% call field(align='right') %}{% endcall %} {% call field(align='right') %}{% endcall %}
@@ -157,14 +157,7 @@
{% if notification.status|format_notification_status_as_url(notification.notification_type) %} {% if notification.status|format_notification_status_as_url(notification.notification_type) %}
<a href="{{ notification.status|format_notification_status_as_url(notification.notification_type) }}"> <a href="{{ notification.status|format_notification_status_as_url(notification.notification_type) }}">
{% endif %} {% endif %}
{% if notification['notification_type'] != "letter" or notification.status in ('virus-scan-failed', 'validation-failed') %} {{ notification.status|format_notification_status(notification.template.template_type) }}
{{ notification.status|format_notification_status(
notification.template.template_type
) }}
{% endif %}
{% if notification.notification_type == "letter" and notification.status in ['permanent-failure', 'cancelled'] %}
Cancelled
{% endif %}
{% if notification.status|format_notification_status_as_url(notification.notification_type) %} {% if notification.status|format_notification_status_as_url(notification.notification_type) %}
</a> </a>
{% endif %} {% endif %}

6
tests/app/main/views/test_activity.py
View File

@@ -603,9 +603,15 @@ def test_big_numbers_and_search_dont_show_for_letters(
"message_type, status, expected_hint_status, single_line", [ "message_type, status, expected_hint_status, single_line", [
('email', 'delivered', 'Delivered 27 September at 5:31pm', True), ('email', 'delivered', 'Delivered 27 September at 5:31pm', True),
('sms', 'delivered', 'Delivered 27 September at 5:31pm', True), ('sms', 'delivered', 'Delivered 27 September at 5:31pm', True),
('letter', 'created', '27 September at 5:30pm', True),
('letter', 'sending', '27 September at 5:30pm', True),
('letter', 'delivered', '27 September at 5:30pm', True), ('letter', 'delivered', '27 September at 5:30pm', True),
('letter', 'received', '27 September at 5:30pm', True),
('letter', 'accepted', '27 September at 5:30pm', True),
('letter', 'virus-scan-failed', 'Virus detected 27 September at 5:30pm', False),
('letter', 'permanent-failure', 'Cancelled 27 September at 5:31pm', False), ('letter', 'permanent-failure', 'Cancelled 27 September at 5:31pm', False),
('letter', 'validation-failed', 'Validation failed 27 September at 5:30pm', False), ('letter', 'validation-failed', 'Validation failed 27 September at 5:30pm', False),
('letter', 'technical-failure', 'Technical failure 27 September at 5:30pm', False),
] ]
) )
def test_sending_status_hint_displays_correctly_on_notifications_page( def test_sending_status_hint_displays_correctly_on_notifications_page(