darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 16:24:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Let users search for letters

Browse Source 
Like we have search by email address or phone number, finding an
individual letter is a common task. At the moment users are having to
click through pages and pages of letters to find the one they’re looking
for.

Users of the API will also be able to search by reference, same as for
emails and text messages. But we only show this hint text to users who
have some API keys.
This commit is contained in:
Chris Hill-Scott
2020-04-21 13:55:23 +01:00
parent 52e966337d
commit 986f2752e0
3 changed files with 53 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/main/views/test_activity.py
View File

@@ -340,7 +340,7 @@ def test_shows_message_when_no_notifications(
(
{},
{},
'Search by email address or phone number',
'Search by recipient',
'',
),
(
@@ -373,6 +373,16 @@ def test_shows_message_when_no_notifications(
'Search by email address',
'test@example.com',
),
(
{
'message_type': 'letter',
},
{
'to': 'Firstname Lastname',
},
'Search by first line of address or file name',
'Firstname Lastname',
),
])
def test_search_recipient_form(
client_request,
@@ -413,9 +423,10 @@ def test_search_recipient_form(
@pytest.mark.parametrize('message_type, expected_search_box_label', [
(None, 'Search by email address, phone number or reference'),
(None, 'Search by recipient or reference'),
('sms', 'Search by phone number or reference'),
('email', 'Search by email address or reference'),
('letter', 'Search by first line of address, file name or reference'),
])
def test_api_users_are_told_they_can_search_by_reference_when_service_has_api_keys(
client_request,
@@ -437,7 +448,7 @@ def test_api_users_are_told_they_can_search_by_reference_when_service_has_api_ke
@pytest.mark.parametrize('message_type, expected_search_box_label', [
(None, 'Search by email address or phone number'),
(None, 'Search by recipient'),
('sms', 'Search by phone number'),
('email', 'Search by email address'),
])
@@ -615,10 +626,10 @@ def test_redacts_templates_that_should_be_redacted(
"message_type, tablist_visible, search_bar_visible", [
('email', True, True),
('sms', True, True),
('letter', False, False)
('letter', False, True)
]
)
def test_big_numbers_and_search_dont_show_for_letters(
def test_big_numbers_dont_show_for_letters(
client_request,
service_one,
mock_get_notifications,