darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add helper function for filtering templates by type

Browse Source 
This code was making the view method more cluttered than it needed to
be. Moving it will help make space for the `post` request handling code.
This commit is contained in:
Chris Hill-Scott
2018-11-08 14:16:46 +00:00
parent 2743216519
commit 980d66bdaa
1 changed files with 22 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
app/main/views/templates.py
View File

@@ -108,18 +108,11 @@ def start_tour(service_id, template_id):
@user_has_permissions() @user_has_permissions()
def choose_template(service_id, template_type='all', template_folder_id=None): def choose_template(service_id, template_type='all', template_folder_id=None):
template_nav_items = [ templates_and_folders_form = TemplateAndFoldersSelectionForm(
( service=current_service,
label, template_type=template_type,
key, current_folder_id=template_folder_id,
url_for( )
'.choose_template', service_id=current_service.id,
template_type=key, template_folder_id=template_folder_id
),
''
)
for label, key in [('All', 'all')] + current_service.available_template_types_as_tuples
]
return render_template( return render_template(
'views/templates/choose.html', 'views/templates/choose.html',
@@ -136,17 +129,28 @@ def choose_template(service_id, template_type='all', template_folder_id=None):
current_service.has_multiple_template_types current_service.has_multiple_template_types
and (len(current_service.all_templates) > 2) and (len(current_service.all_templates) > 2)
), ),
template_nav_items=template_nav_items, template_nav_items=get_template_nav_items(template_folder_id),
template_type=template_type, template_type=template_type,
search_form=SearchTemplatesForm(), search_form=SearchTemplatesForm(),
templates_and_folders_form=TemplateAndFoldersSelectionForm( templates_and_folders_form=templates_and_folders_form,
service=current_service,
template_type=template_type,
current_folder_id=template_folder_id,
)
) )
def get_template_nav_items(template_folder_id):
return [
(
label,
key,
url_for(
'.choose_template', service_id=current_service.id,
template_type=key, template_folder_id=template_folder_id
),
''
)
for label, key in [('All', 'all')] + current_service.available_template_types_as_tuples
]
@main.route("/services/<service_id>/templates/<template_id>.<filetype>") @main.route("/services/<service_id>/templates/<template_id>.<filetype>")
@login_required @login_required
@user_has_permissions() @user_has_permissions()