From 2cfd22b20ceab2afaec79dee7396579661bfd5a9 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 5 Jul 2021 14:33:02 +0100 Subject: [PATCH] Remove empty state step before choosing areas MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We had some kind of idea that having this empty page would introduce the idea of choosing areas and reinforce that you are building up a list of areas. But since the journey is now so simple with the button to create an alert directly on the dashboard page, maybe people don’t need this extra orientation. --- app/main/views/broadcast.py | 4 ++-- tests/app/main/views/test_broadcast.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/main/views/broadcast.py b/app/main/views/broadcast.py index 1ad578a58..8d89f3a98 100644 --- a/app/main/views/broadcast.py +++ b/app/main/views/broadcast.py @@ -150,7 +150,7 @@ def write_new_broadcast(service_id): reference=form.name.data, ) return redirect(url_for( - '.preview_broadcast_areas', + '.choose_broadcast_library', service_id=current_service.id, broadcast_message_id=broadcast_message.id, )) @@ -166,7 +166,7 @@ def write_new_broadcast(service_id): @service_has_permission('broadcast') def broadcast(service_id, template_id): return redirect(url_for( - '.preview_broadcast_areas', + '.choose_broadcast_library', service_id=current_service.id, broadcast_message_id=BroadcastMessage.create( service_id=service_id, diff --git a/tests/app/main/views/test_broadcast.py b/tests/app/main/views/test_broadcast.py index 126e31509..c304e76bf 100644 --- a/tests/app/main/views/test_broadcast.py +++ b/tests/app/main/views/test_broadcast.py @@ -737,7 +737,7 @@ def test_write_new_broadcast_posts( 'template_content': 'This is a test', }, _expected_redirect=url_for( - '.preview_broadcast_areas', + '.choose_broadcast_library', service_id=SERVICE_ONE_ID, broadcast_message_id=fake_uuid, _external=True, @@ -795,7 +795,7 @@ def test_broadcast_page( service_id=SERVICE_ONE_ID, template_id=fake_uuid, _expected_redirect=url_for( - '.preview_broadcast_areas', + '.choose_broadcast_library', service_id=SERVICE_ONE_ID, broadcast_message_id=fake_uuid, _external=True,