darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-15 07:18:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

More formatting fixes for tests

Browse Source 
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
This commit is contained in:
Carlo Costino
2023-09-06 18:29:04 -04:00
parent 47695b97d3
commit 95ba7c3099
7 changed files with 41 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/utils/test_csv.py
View File

@@ -65,8 +65,8 @@ def _get_notifications_csv(
return _get
@pytest.fixture(scope="function")
def _get_notifications_csv_mock(
@pytest.fixture()
def get_notifications_csv_mock(
mocker,
api_user_active,
):
@@ -77,7 +77,7 @@ def _get_notifications_csv_mock(
@pytest.mark.parametrize(
"created_by_name, expected_content",
("created_by_name", "expected_content"),
[
(
None,
@@ -114,7 +114,7 @@ def test_generate_notifications_csv_without_job(
@pytest.mark.parametrize(
"original_file_contents, expected_column_headers, expected_1st_row",
("original_file_contents", "expected_column_headers", "expected_1st_row"),
[
(
"""
@@ -211,7 +211,7 @@ def test_generate_notifications_csv_without_job(
def test_generate_notifications_csv_returns_correct_csv_file(
notify_admin,
mocker,
_get_notifications_csv_mock,
get_notifications_csv_mock,
original_file_contents,
expected_column_headers,
expected_1st_row,
@@ -231,11 +231,11 @@ def test_generate_notifications_csv_returns_correct_csv_file(
def test_generate_notifications_csv_only_calls_once_if_no_next_link(
notify_admin,
_get_notifications_csv_mock,
get_notifications_csv_mock,
):
list(generate_notifications_csv(service_id="1234"))
assert _get_notifications_csv_mock.call_count == 1
assert get_notifications_csv_mock.call_count == 1
@pytest.mark.parametrize("job_id", ["some", None])
@@ -303,8 +303,14 @@ MockRecipients = namedtuple(
@pytest.mark.parametrize(
"rows_with_bad_recipients, rows_with_missing_data, "
"rows_with_message_too_long, rows_with_empty_message, template_type, expected_errors",
(
"rows_with_bad_recipients",
"rows_with_missing_data",
"rows_with_message_too_long",
"rows_with_empty_message",
"template_type",
"expected_errors",
),
[
([], [], [], [], "sms", []),
({2}, [], [], [], "sms", ["fix 1 phone number"]),