darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-13 06:54:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make copy to clipboard work with prefixes

Browse Source 
The prefix was being included in the selection
copied.
This commit is contained in:
Tom Byers
2020-09-15 12:53:58 +01:00
parent c2e737b323
commit 956f5d4c3e
3 changed files with 52 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tests/javascripts/apiKey.test.js
View File

@@ -33,16 +33,12 @@ describe('API key', () => {
};
beforeAll(() => {
beforeEach(() => {
// mock objects used to manipulate the page selection
selectionMock = new helpers.SelectionMock(jest);
rangeMock = new helpers.RangeMock(jest);
});
beforeEach(() => {
// plug gaps in JSDOM's API for manipulation of selections
window.getSelection = jest.fn(() => selectionMock);
document.createRange = jest.fn(() => rangeMock);
@@ -325,7 +321,7 @@ describe('API key', () => {
describe("If it's one of many in the page", () => {
test("the button should have a hidden suffix naming the id it is for", () => {
beforeEach(() => {
// If 'thing' (what the id is) and 'name' (its specific idenifier on the page) are
// different, it will be one of others called the same 'thing'.
@@ -338,12 +334,31 @@ describe('API key', () => {
helpers.triggerEvent(component.querySelector('button'), 'click');
});
test("the button should have a hidden suffix naming the id it is for", () => {
const buttonSuffix = component.querySelector('button .govuk-visually-hidden');
expect(buttonSuffix).not.toBeNull();
expect(buttonSuffix.textContent).toEqual(' for Default');
});
test("the copied selection shouldn't include the prefix of the id", () => {
// that selection (a range) should have a startOffset past the first two nodes:
// index 0: text node containing the whitespace before the prefix
// index 1: the prefix node
expect(rangeMock.setStart).toHaveBeenCalled();
expect(rangeMock.setStart.mock.calls[0][1]).toEqual(2);
// reset any methods in the global space
window.queryCommandSupported = undefined;
window.getSelection = undefined;
document.createRange = undefined;
});
});
describe("If it's the only one on the page", () => {
@@ -373,6 +388,18 @@ describe('API key', () => {
})
test("the copied selection should match the id", () => {
// that selection (a range) shouldn't call setStart to avoid the prefix:
expect(rangeMock.setStart).not.toHaveBeenCalled();
// reset any methods in the global space
window.queryCommandSupported = undefined;
window.getSelection = undefined;
document.createRange = undefined;
});
});
});