darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2025-12-14 00:52:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove some fixtures

Browse Source
This commit is contained in:
Kenneth Kehl
2024-05-29 14:18:08 -07:00
parent 17fec1c99e
commit 9368f6a496
5 changed files with 174 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
notifications_utils/s3.py
View File

@@ -93,6 +93,17 @@ def s3download(
)
s3 = session.resource("s3", config=AWS_CLIENT_CONFIG)
key = s3.Object(bucket_name, filename)
# This 'proves' that use of moto in the relevant tests in test_send.py
# mocks everything related to S3. What you will see in the logs is:
# Exception: CREATED AT <MagicMock name='resource().Bucket().creation_date' id='4665562448'>
#
# raise Exception(f"CREATED AT {_s3.Bucket(bucket_name).creation_date}")
if os.getenv("NOTIFY_ENVIRONMENT") == "test":
teststr = str(s3.Bucket(bucket_name).creation_date).lower()
if "magicmock" not in teststr:
raise Exception(
f"xxxxxtest not mocked, use @mock_aws creation date is {teststr}"
)
return key.get()["Body"]
except botocore.exceptions.ClientError as error:
raise S3ObjectNotFound(error.response, error.operation_name)