darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 05:48:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3917 from alphagov/set-webauthn-after-adding-token

Browse Source 
Set user to WebAuthn login after adding token
This commit is contained in:
Chris Hill-Scott
2021-06-09 10:18:56 +01:00
committed by GitHub
parent 1b459d6692 f8f718dff8
commit 9344eabceb
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/main/views/webauthn_credentials.py
View File

@@ -52,9 +52,8 @@ def webauthn_complete_register():
current_app.logger.info(f'User {current_user.id} could not register a new webauthn token - {e}') current_app.logger.info(f'User {current_user.id} could not register a new webauthn token - {e}')
return cbor.encode(str(e)), 400 return cbor.encode(str(e)), 400
user_api_client.create_webauthn_credential_for_user( current_user.create_webauthn_credential(credential)
current_user.id, credential current_user.update(auth_type='webauthn_auth')
)
flash(( flash((
'Registration complete. Next time you sign in to Notify ' 'Registration complete. Next time you sign in to Notify '

5
app/models/user.py
View File

@@ -360,6 +360,11 @@ class User(JSONModel, UserMixin):
for credential in self.webauthn_credentials for credential in self.webauthn_credentials
] ]
def create_webauthn_credential(self, credential):
user_api_client.create_webauthn_credential_for_user(
self.id, credential
)
def serialize(self): def serialize(self):
dct = { dct = {
"id": self.id, "id": self.id,

5
tests/app/main/views/test_webauthn_credentials.py
View File

@@ -112,6 +112,7 @@ def test_begin_register_stores_state_in_session(
def test_complete_register_creates_credential( def test_complete_register_creates_credential(
platform_admin_user, platform_admin_user,
platform_admin_client, platform_admin_client,
mock_update_user_attribute,
mocker, mocker,
): ):
with platform_admin_client.session_transaction() as session: with platform_admin_client.session_transaction() as session:
@@ -134,6 +135,10 @@ def test_complete_register_creates_credential(
assert response.status_code == 200 assert response.status_code == 200
credential_mock.assert_called_once_with('state', 'public_key_credential') credential_mock.assert_called_once_with('state', 'public_key_credential')
user_api_mock.assert_called_once_with(platform_admin_user['id'], 'cred') user_api_mock.assert_called_once_with(platform_admin_user['id'], 'cred')
mock_update_user_attribute.assert_called_once_with(
platform_admin_user['id'],
auth_type='webauthn_auth',
)
def test_complete_register_clears_session( def test_complete_register_clears_session(