darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

notify-admin-530 remove email info in service name settings

Browse Source
This commit is contained in:
Kenneth Kehl
2023-07-21 08:24:10 -07:00
parent 773298fa54
commit 933a4808e4
3 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/templates/views/service-settings/name-local.html
View File

@@ -28,14 +28,12 @@
<div class="form-group"> <div class="form-group">
{% if current_service.prefix_sms %} {% if current_service.prefix_sms %}
<p>Users will see your service name at the start of every text message</p> <p>Users will see your service name at the start of every text message</p>
<!-- <ul class="govuk-list govuk-list--bullet">
<li>at the start of every text message</li>
<li>as your email sender name</li>
</ul> -->
{% else %} {% else %}
<p>Users will see your service name as your email sender name.</p> <p>Users will see your service name as your email sender name.</p>
{% endif %} {% endif %}
</div> </div>
<p>The service name you enter here will appear at the beginning of each text message, unless you turn off this off in Settings > Start text message with service name.
{% call form_wrapper() %} {% call form_wrapper() %}
{{ form.name }} {{ form.name }}

14
app/templates/views/service-settings/name.html
View File

@@ -22,17 +22,17 @@
<p class="govuk-body">You should only use an acronym or initialism if your users are already familiar with it.</p> <p class="govuk-body">You should only use an acronym or initialism if your users are already familiar with it.</p>
<div class="form-group"> <div>
{% if current_service.prefix_sms %} {% if current_service.prefix_sms %}
<p>Users will see your service name:</p>
<ul class="list-bullet"> <p class="govuk-body">Users will see your service name at the start of every text message</p>
<li>at the start of every text message</li>
<li>as your email sender name</li>
</ul>
{% else %} {% else %}
<p>Users will see your service name as your email sender name.</p> <p class="govuk-body">Users will see your service name as your email sender name.</p>
{% endif %} {% endif %}
</div> </div>
<p class="govuk-body">The service name you enter here will appear at the beginning of each text message, unless you turn off this off in Settings > Start text message with service name.
{% call form_wrapper() %} {% call form_wrapper() %}
{{ form.name }} {{ form.name }}

7
tests/app/main/views/service_settings/test_service_settings.py
View File

@@ -254,10 +254,9 @@ def test_should_show_service_name(
assert page.select_one( assert page.select_one(
'main .govuk-body' 'main .govuk-body'
).text == 'Your service name should tell users what the message is about as well as who it’s from.' ).text == 'Your service name should tell users what the message is about as well as who it’s from.'
assert normalize_spaces(page.select_one('main ul').text) == (
'at the start of every text message ' assert "The service name you enter here will appear at the beginning of each text message, unless" in page.text
'as your email sender name'
)
app.service_api_client.get_service.assert_called_with(SERVICE_ONE_ID) app.service_api_client.get_service.assert_called_with(SERVICE_ONE_ID)