mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-07 03:28:25 -04:00
split test_uploads.py into three separate folders
one for the upload hub and list pages one for contact list uploading/editing/viewing one for sending a letter no tests added/removed/changed
This commit is contained in:
Leo Hemsted
394
tests/app/main/views/uploads/test_upload_hub.py
Normal file
394
tests/app/main/views/uploads/test_upload_hub.py
Normal file
@@ -0,0 +1,394 @@
|
||||
import re
|
||||
|
||||
import pytest
|
||||
from flask import url_for
|
||||
from freezegun import freeze_time
|
||||
|
||||
from app.utils import normalize_spaces
|
||||
from tests.conftest import (
|
||||
SERVICE_ONE_ID,
|
||||
create_active_caseworking_user,
|
||||
create_active_user_with_permissions,
|
||||
create_platform_admin_user,
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.parametrize('extra_permissions', (
|
||||
pytest.param(
|
||||
[],
|
||||
marks=pytest.mark.xfail(raises=AssertionError),
|
||||
),
|
||||
pytest.param(
|
||||
['upload_letters'],
|
||||
marks=pytest.mark.xfail(raises=AssertionError),
|
||||
),
|
||||
['letter'],
|
||||
['letter', 'upload_letters'],
|
||||
))
|
||||
def test_upload_letters_button_only_with_letters_permission(
|
||||
client_request,
|
||||
service_one,
|
||||
mock_get_uploads,
|
||||
mock_get_jobs,
|
||||
mock_get_no_contact_lists,
|
||||
extra_permissions,
|
||||
):
|
||||
service_one['permissions'] += extra_permissions
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
assert page.find('a', text=re.compile('Upload a letter'))
|
||||
|
||||
|
||||
@pytest.mark.parametrize('user', (
|
||||
create_platform_admin_user(),
|
||||
create_active_user_with_permissions(),
|
||||
))
|
||||
def test_all_users_have_upload_contact_list(
|
||||
client_request,
|
||||
mock_get_uploads,
|
||||
mock_get_jobs,
|
||||
mock_get_no_contact_lists,
|
||||
user,
|
||||
):
|
||||
client_request.login(user)
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
button = page.find('a', text=re.compile('Upload an emergency contact list'))
|
||||
assert button
|
||||
assert button['href'] == url_for(
|
||||
'main.upload_contact_list', service_id=SERVICE_ONE_ID,
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.parametrize('extra_permissions, expected_empty_message', (
|
||||
([], (
|
||||
'You have not uploaded any files recently.'
|
||||
)),
|
||||
(['letter'], (
|
||||
'You have not uploaded any files recently. '
|
||||
'Upload a letter and Notify will print, pack and post it for you.'
|
||||
)),
|
||||
))
|
||||
def test_get_upload_hub_with_no_uploads(
|
||||
mocker,
|
||||
client_request,
|
||||
service_one,
|
||||
mock_get_no_uploads,
|
||||
mock_get_no_contact_lists,
|
||||
extra_permissions,
|
||||
expected_empty_message,
|
||||
):
|
||||
mocker.patch('app.job_api_client.get_jobs', return_value={'data': []})
|
||||
service_one['permissions'] += extra_permissions
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
assert normalize_spaces(' '.join(
|
||||
paragraph.text for paragraph in page.select('main p')
|
||||
)) == expected_empty_message
|
||||
assert not page.select('.file-list-filename')
|
||||
|
||||
|
||||
@freeze_time('2017-10-10 10:10:10')
|
||||
def test_get_upload_hub_page(
|
||||
mocker,
|
||||
client_request,
|
||||
service_one,
|
||||
mock_get_uploads,
|
||||
mock_get_no_contact_lists,
|
||||
):
|
||||
mocker.patch('app.job_api_client.get_jobs', return_value={'data': []})
|
||||
service_one['permissions'] += ['letter', 'upload_letters']
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
assert page.find('h1').text == 'Uploads'
|
||||
assert page.find('a', text=re.compile('Upload a letter')).attrs['href'] == url_for(
|
||||
'main.upload_letter', service_id=SERVICE_ONE_ID
|
||||
)
|
||||
|
||||
uploads = page.select('tbody tr')
|
||||
|
||||
assert len(uploads) == 3
|
||||
|
||||
assert normalize_spaces(uploads[0].text.strip()) == (
|
||||
'Uploaded letters '
|
||||
'Printing today at 5:30pm '
|
||||
'33 letters'
|
||||
)
|
||||
assert uploads[0].select_one('a.file-list-filename-large')['href'] == url_for(
|
||||
'main.uploaded_letters',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
letter_print_day='2017-10-10',
|
||||
)
|
||||
|
||||
assert normalize_spaces(uploads[1].text.strip()) == (
|
||||
'some.csv '
|
||||
'Sent 1 January 2016 at 11:09am '
|
||||
'0 sending 8 delivered 2 failed'
|
||||
)
|
||||
assert uploads[1].select_one('a.file-list-filename-large')['href'] == (
|
||||
'/services/{}/jobs/job_id_1'.format(SERVICE_ONE_ID)
|
||||
)
|
||||
|
||||
assert normalize_spaces(uploads[2].text.strip()) == (
|
||||
'some.pdf '
|
||||
'Sent 1 January 2016 at 11:09am '
|
||||
'Firstname Lastname '
|
||||
'123 Example Street'
|
||||
)
|
||||
assert normalize_spaces(str(uploads[2].select_one('.govuk-body'))) == (
|
||||
'<p class="govuk-body letter-recipient-summary"> '
|
||||
'Firstname Lastname<br/> '
|
||||
'123 Example Street<br/> '
|
||||
'</p>'
|
||||
)
|
||||
assert uploads[2].select_one('a.file-list-filename-large')['href'] == (
|
||||
'/services/{}/notification/letter_id_1'.format(SERVICE_ONE_ID)
|
||||
)
|
||||
|
||||
|
||||
@freeze_time('2020-02-02 14:00')
|
||||
def test_get_uploaded_letters(
|
||||
mocker,
|
||||
client_request,
|
||||
service_one,
|
||||
mock_get_uploaded_letters,
|
||||
):
|
||||
page = client_request.get(
|
||||
'main.uploaded_letters',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
letter_print_day='2020-02-02'
|
||||
)
|
||||
assert page.select_one('.govuk-back-link')['href'] == url_for(
|
||||
'main.uploads',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
)
|
||||
assert normalize_spaces(
|
||||
page.select_one('h1').text
|
||||
) == (
|
||||
'Uploaded letters'
|
||||
)
|
||||
assert normalize_spaces(
|
||||
page.select('main p')[0].text
|
||||
) == (
|
||||
'1,234 letters'
|
||||
)
|
||||
assert normalize_spaces(
|
||||
page.select('main p')[1].text
|
||||
) == (
|
||||
'Printing starts today at 5:30pm'
|
||||
)
|
||||
|
||||
assert [
|
||||
normalize_spaces(row.text)
|
||||
for row in page.select('tbody tr')
|
||||
] == [
|
||||
(
|
||||
'Homer-Simpson.pdf '
|
||||
'742 Evergreen Terrace '
|
||||
'2 February at 1:59pm'
|
||||
),
|
||||
(
|
||||
'Kevin-McCallister.pdf '
|
||||
'671 Lincoln Avenue, Winnetka '
|
||||
'2 February at 12:59pm'
|
||||
),
|
||||
]
|
||||
|
||||
assert [
|
||||
link['href'] for link in page.select('tbody tr a')
|
||||
] == [
|
||||
url_for(
|
||||
'main.view_notification',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
notification_id='03e34025-be54-4d43-8e6a-fb1ea0fd1f29',
|
||||
from_uploaded_letters='2020-02-02',
|
||||
),
|
||||
url_for(
|
||||
'main.view_notification',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
notification_id='fc090d91-e761-4464-9041-9c4594c96a35',
|
||||
from_uploaded_letters='2020-02-02',
|
||||
),
|
||||
]
|
||||
|
||||
next_page_link = page.select_one('a[rel=next]')
|
||||
prev_page_link = page.select_one('a[rel=previous]')
|
||||
assert next_page_link['href'] == url_for(
|
||||
'main.uploaded_letters', service_id=SERVICE_ONE_ID, letter_print_day='2020-02-02', page=2
|
||||
)
|
||||
assert normalize_spaces(next_page_link.text) == (
|
||||
'Next page '
|
||||
'page 2'
|
||||
)
|
||||
assert prev_page_link['href'] == url_for(
|
||||
'main.uploaded_letters', service_id=SERVICE_ONE_ID, letter_print_day='2020-02-02', page=0
|
||||
)
|
||||
assert normalize_spaces(prev_page_link.text) == (
|
||||
'Previous page '
|
||||
'page 0'
|
||||
)
|
||||
|
||||
mock_get_uploaded_letters.assert_called_once_with(
|
||||
SERVICE_ONE_ID,
|
||||
letter_print_day='2020-02-02',
|
||||
page=1,
|
||||
)
|
||||
|
||||
|
||||
@freeze_time('2020-02-02 14:00')
|
||||
def test_get_empty_uploaded_letters_page(
|
||||
mocker,
|
||||
client_request,
|
||||
service_one,
|
||||
mock_get_no_uploaded_letters,
|
||||
):
|
||||
page = client_request.get(
|
||||
'main.uploaded_letters',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
letter_print_day='2020-02-02'
|
||||
)
|
||||
page.select_one('main table')
|
||||
|
||||
assert not page.select('tbody tr')
|
||||
assert not page.select_one('a[rel=next]')
|
||||
assert not page.select_one('a[rel=previous]')
|
||||
|
||||
|
||||
@freeze_time('2020-02-02')
|
||||
def test_get_uploaded_letters_passes_through_page_argument(
|
||||
mocker,
|
||||
client_request,
|
||||
service_one,
|
||||
mock_get_uploaded_letters,
|
||||
):
|
||||
client_request.get(
|
||||
'main.uploaded_letters',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
letter_print_day='2020-02-02',
|
||||
page=99,
|
||||
)
|
||||
mock_get_uploaded_letters.assert_called_once_with(
|
||||
SERVICE_ONE_ID,
|
||||
letter_print_day='2020-02-02',
|
||||
page=99,
|
||||
)
|
||||
|
||||
|
||||
def test_get_uploaded_letters_404s_for_bad_page_arguments(
|
||||
mocker,
|
||||
client_request,
|
||||
):
|
||||
client_request.get(
|
||||
'main.uploaded_letters',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
letter_print_day='2020-02-02',
|
||||
page='one',
|
||||
_expected_status=404,
|
||||
)
|
||||
|
||||
|
||||
def test_get_uploaded_letters_404s_for_invalid_date(
|
||||
mocker,
|
||||
client_request,
|
||||
):
|
||||
client_request.get(
|
||||
'main.uploaded_letters',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
letter_print_day='1234-56-78',
|
||||
_expected_status=404,
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.parametrize('user', (
|
||||
create_active_caseworking_user(),
|
||||
create_active_user_with_permissions(),
|
||||
))
|
||||
@freeze_time("2012-12-12 12:12")
|
||||
def test_uploads_page_shows_scheduled_jobs(
|
||||
mocker,
|
||||
client_request,
|
||||
mock_get_no_uploads,
|
||||
mock_get_jobs,
|
||||
mock_get_no_contact_lists,
|
||||
user,
|
||||
):
|
||||
client_request.login(user)
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
|
||||
assert [
|
||||
normalize_spaces(row.text) for row in page.select('tr')
|
||||
] == [
|
||||
(
|
||||
'File Status'
|
||||
),
|
||||
(
|
||||
'even_later.csv '
|
||||
'Sending 1 January 2016 at 11:09pm '
|
||||
'1 text message waiting to send'
|
||||
),
|
||||
(
|
||||
'send_me_later.csv '
|
||||
'Sending 1 January 2016 at 11:09am '
|
||||
'1 text message waiting to send'
|
||||
),
|
||||
]
|
||||
assert not page.select('.table-empty-message')
|
||||
|
||||
|
||||
@freeze_time('2020-03-15')
|
||||
def test_uploads_page_shows_contact_lists_first(
|
||||
mocker,
|
||||
client_request,
|
||||
mock_get_no_uploads,
|
||||
mock_get_jobs,
|
||||
mock_get_contact_lists,
|
||||
):
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
|
||||
assert [
|
||||
normalize_spaces(row.text) for row in page.select('tr')
|
||||
] == [
|
||||
(
|
||||
'File Status'
|
||||
),
|
||||
(
|
||||
'phone number list.csv '
|
||||
'Uploaded 13 March at 1:00pm '
|
||||
'123 saved phone numbers'
|
||||
),
|
||||
(
|
||||
'EmergencyContactList.xls '
|
||||
'Uploaded 13 March at 10:59am '
|
||||
'100 saved email addresses'
|
||||
),
|
||||
(
|
||||
'even_later.csv '
|
||||
'Sending 1 January 2016 at 11:09pm '
|
||||
'1 text message waiting to send'
|
||||
),
|
||||
(
|
||||
'send_me_later.csv '
|
||||
'Sending 1 January 2016 at 11:09am '
|
||||
'1 text message waiting to send'
|
||||
),
|
||||
]
|
||||
assert page.select_one('.file-list-filename-large')['href'] == url_for(
|
||||
'main.contact_list',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
contact_list_id='d7b0bd1a-d1c7-4621-be5c-3c1b4278a2ad',
|
||||
)
|
||||
|
||||
|
||||
def test_get_uploads_shows_pagination(
|
||||
client_request,
|
||||
active_user_with_permissions,
|
||||
mock_get_jobs,
|
||||
mock_get_uploads,
|
||||
mock_get_no_contact_lists,
|
||||
):
|
||||
page = client_request.get('main.uploads', service_id=SERVICE_ONE_ID)
|
||||
|
||||
assert normalize_spaces(page.select_one('.next-page').text) == (
|
||||
'Next page '
|
||||
'page 2'
|
||||
)
|
||||
assert normalize_spaces(page.select_one('.previous-page').text) == (
|
||||
'Previous page '
|
||||
'page 0'
|
||||
)
|
||||
Reference in New Issue
Block a user