darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Split "get_available_choices" by branding type

Browse Source 
We already had different functionality for email branding and will
soon be adding more for email branding pools.

Note that the "get_available_choices" class method was only used for
email branding - we can do it in the constructor for letters.
This commit is contained in:
Ben Thorner
2022-03-22 16:56:50 +00:00
parent f022836f4d
commit 8f55972aae
4 changed files with 62 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/app/utils/test_branding.py
View File

@@ -3,11 +3,11 @@ from unittest.mock import PropertyMock
import pytest
from app.models.service import Service
from app.utils.branding import get_available_choices
from app.utils.branding import get_email_choices, get_letter_choices
from tests import organisation_json
@pytest.mark.parametrize('branding_type', ['email', 'letter'])
@pytest.mark.parametrize('function', [get_email_choices, get_letter_choices])
@pytest.mark.parametrize('org_type, expected_options', [
('central', []),
('local', []),
@@ -17,20 +17,20 @@ from tests import organisation_json
('emergency_service', []),
('other', []),
])
def test_get_available_choices_service_not_assigned_to_org(
def test_get_choices_service_not_assigned_to_org(
service_one,
branding_type,
function,
org_type,
expected_options,
):
service_one['organisation_type'] = org_type
service = Service(service_one)
options = get_available_choices(service, branding_type=branding_type)
options = function(service)
assert list(options) == expected_options
@pytest.mark.parametrize('branding_type', ['email', 'letter'])
@pytest.mark.parametrize('function', [get_email_choices, get_letter_choices])
@pytest.mark.parametrize('org_type, expected_options', [
('local', [('organisation', 'Test Organisation')]),
('nhs_central', [('nhs', 'NHS')]),
@@ -39,10 +39,10 @@ def test_get_available_choices_service_not_assigned_to_org(
('emergency_service', [('organisation', 'Test Organisation')]),
('other', [('organisation', 'Test Organisation')]),
])
def test_get_available_choices_service_assigned_to_org(
def test_get_choices_service_assigned_to_org(
mocker,
service_one,
branding_type,
function,
org_type,
expected_options,
mock_get_service_organisation,
@@ -54,7 +54,7 @@ def test_get_available_choices_service_assigned_to_org(
return_value=organisation_json(organisation_type=org_type)
)
options = get_available_choices(service, branding_type=branding_type)
options = function(service)
assert list(options) == expected_options
@@ -69,7 +69,7 @@ def test_get_available_choices_service_assigned_to_org(
('organisation', 'Test Organisation'),
])
])
def test_get_available_choices_email_branding_central_org(
def test_get_email_choices_central_org(
mocker,
service_one,
service_branding,
@@ -89,11 +89,11 @@ def test_get_available_choices_email_branding_central_org(
return_value=service_branding,
)
options = get_available_choices(service, branding_type='email')
options = get_email_choices(service)
assert list(options) == expected_options
def test_get_available_choices_letter_branding_set(
def test_get_letter_choices_branding_set(
mocker,
service_one,
mock_get_service_organisation,
@@ -111,7 +111,7 @@ def test_get_available_choices_letter_branding_set(
return_value='some-random-branding',
)
options = get_available_choices(service, branding_type='letter')
options = get_letter_choices(service)
assert list(options) == [
('organisation', 'Test Organisation'),
]