From 8db280317fca7b01651e8693198f3e5cc8ba7a3f Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Tue, 18 May 2021 15:14:06 +0100 Subject: [PATCH] Rename helper method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is ambiguous, as it's not used in a lot of the views. There’s precendent for naming these kind of methods here: https://github.com/alphagov/notifications-admin/blob/06cc5b58c7367b6e29dc71a5851492f20ef53a55/app/main/views/broadcast.py#L238 --- app/main/views/broadcast.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/main/views/broadcast.py b/app/main/views/broadcast.py index be47568fa..83dab3b44 100644 --- a/app/main/views/broadcast.py +++ b/app/main/views/broadcast.py @@ -22,7 +22,7 @@ from app.models.broadcast_message import BroadcastMessage, BroadcastMessages from app.utils import service_has_permission, user_has_permissions -def get_back_link_endpoint(): +def _get_back_link_from_view_broadcast_endpoint(): return { 'main.view_current_broadcast': '.broadcast_dashboard', 'main.view_previous_broadcast': '.broadcast_dashboard_previous', @@ -402,7 +402,7 @@ def view_broadcast(service_id, broadcast_message_id): 'views/broadcast/view-message.html', broadcast_message=broadcast_message, back_link=url_for( - get_back_link_endpoint(), + _get_back_link_from_view_broadcast_endpoint(), service_id=current_service.id, ), form=ConfirmBroadcastForm( @@ -450,7 +450,7 @@ def approve_broadcast_message(service_id, broadcast_message_id): 'views/broadcast/view-message.html', broadcast_message=broadcast_message, back_link=url_for( - get_back_link_endpoint(), + _get_back_link_from_view_broadcast_endpoint(), service_id=current_service.id, ), form=form,