Refactored reports to use pregenerated docs instead (#2831)

* Refactored reports to use pregenerated docs instead

* Fixed e2e test

* Fixed anothr bug

* Cleanup

* Fixed timezone conversion

* Updated ref files

* Updated reference files, refreshed ui/ux for report generation. Buttons toggle on and off based on if report exists

* Fixed linting errors, removed pytz

* Fixed test failure

* e2e test fix

* Speeding up unit tests

* Removed python time library that was causing performance issues with unit tests

* Updated poetry lock

* Unit test improvements

* Made change that ken reccomended

tests/app/main/views/test_download_notifications_csv_s3.py

@@ -0,0 +1,111 @@
+from unittest.mock import patch
+
+from app.main.views.notifications import PERIOD_TO_S3_FILENAME
+from tests.conftest import SERVICE_ONE_ID
+
+
+def test_period_to_s3_filename_mapping():
+    assert PERIOD_TO_S3_FILENAME["one_day"] == "1-day-report"
+    assert PERIOD_TO_S3_FILENAME["three_day"] == "3-day-report"
+    assert PERIOD_TO_S3_FILENAME["five_day"] == "5-day-report"
+    assert PERIOD_TO_S3_FILENAME["seven_day"] == "7-day-report"
+
+
+@patch("app.main.views.notifications.s3download")
+@patch("app.main.views.notifications.generate_notifications_csv")
+def test_job_based_reports_dont_use_s3(
+    mock_generate_csv,
+    mock_s3download,
+    client_request,
+    service_one,
+    mock_get_service_data_retention,
+):
+    mock_generate_csv.return_value = iter(["test,data\n"])
+
+    response = client_request.get_response(
+        "main.download_notifications_csv",
+        service_id=SERVICE_ONE_ID,
+        number_of_days="one_day",
+        message_type="sms",
+        job_id="test-job-123",
+        _test_page_title=False,
+    )
+
+    mock_s3download.assert_not_called()
+    mock_generate_csv.assert_called_once()
+    assert response.status_code == 200
+
+
+@patch("app.main.views.notifications.s3download")
+@patch("app.main.views.notifications.generate_notifications_csv")
+def test_general_reports_use_s3(
+    mock_generate_csv,
+    mock_s3download,
+    client_request,
+    service_one,
+    mock_get_service_data_retention,
+):
+    mock_s3download.return_value = b"s3,csv,content\n"
+
+    response = client_request.get_response(
+        "main.download_notifications_csv",
+        service_id=SERVICE_ONE_ID,
+        number_of_days="three_day",
+        message_type="sms",
+        _test_page_title=False,
+    )
+
+    mock_s3download.assert_called_once_with(SERVICE_ONE_ID, "3-day-report")
+    mock_generate_csv.assert_not_called()
+    assert response.status_code == 200
+
+
+@patch("app.main.views.notifications.s3download")
+def test_missing_s3_file_redirects_gracefully(
+    mock_s3download,
+    client_request,
+    service_one,
+    mock_get_service_data_retention,
+):
+    from notifications_utils.s3 import S3ObjectNotFound
+
+    mock_s3download.side_effect = S3ObjectNotFound(
+        {"Error": {"Code": "NoSuchKey"}}, "GetObject"
+    )
+
+    # Verify that when an S3 file is missing, we redirect gracefully
+    # instead of showing a 500 error
+    client_request.get(
+        "main.download_notifications_csv",
+        service_id=SERVICE_ONE_ID,
+        number_of_days="five_day",
+        message_type="sms",
+        _expected_redirect=f"/services/{SERVICE_ONE_ID}/notifications/sms?status=sending,delivered,failed",
+    )
+
+    # The redirect happens, which means no 500 error occurred
+    mock_s3download.assert_called_once_with(SERVICE_ONE_ID, "5-day-report")
+
+
+@patch("app.main.views.notifications.convert_s3_csv_timestamps")
+@patch("app.main.views.notifications.s3download")
+def test_s3_csv_gets_timezone_converted(
+    mock_s3download,
+    mock_convert,
+    client_request,
+    service_one,
+    mock_get_service_data_retention,
+):
+    mock_s3download.return_value = b"csv,data"
+    mock_convert.return_value = iter(["converted,csv,data\n"])
+
+    response = client_request.get_response(
+        "main.download_notifications_csv",
+        service_id=SERVICE_ONE_ID,
+        number_of_days="three_day",
+        message_type="sms",
+        _test_page_title=False,
+    )
+
+    mock_convert.assert_called_once_with(b"csv,data")
+    assert response.status_code == 200