darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 01:55:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1691 from alphagov/strip-spaces-sign-in

Browse Source 
Strip spaces from email addresses when signing in
This commit is contained in:
Chris Hill-Scott
2017-12-08 16:21:26 +00:00
committed by GitHub
parent ac547623b1 bef8e8887b
commit 8cc478f731
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/main/views/sign_in.py
View File

@@ -30,6 +30,9 @@ def sign_in():
return redirect(url_for('main.choose_service')) return redirect(url_for('main.choose_service'))
form = LoginForm() form = LoginForm()
if form.email_address.data:
form.email_address.data = form.email_address.data.strip()
if form.validate_on_submit(): if form.validate_on_submit():
user = user_api_client.get_user_by_email_or_none(form.email_address.data) user = user_api_client.get_user_by_email_or_none(form.email_address.data)

8
tests/app/main/views/test_sign_in.py
View File

@@ -77,6 +77,10 @@ def test_logged_in_user_redirects_to_choose_service(
assert response.location == url_for('main.choose_service', _external=True) assert response.location == url_for('main.choose_service', _external=True)
@pytest.mark.parametrize('email_address', [
'valid@example.gov.uk',
' valid@example.gov.uk ',
])
def test_process_sms_auth_sign_in_return_2fa_template( def test_process_sms_auth_sign_in_return_2fa_template(
client, client,
api_user_active, api_user_active,
@@ -84,14 +88,16 @@ def test_process_sms_auth_sign_in_return_2fa_template(
mock_get_user, mock_get_user,
mock_get_user_by_email, mock_get_user_by_email,
mock_verify_password, mock_verify_password,
email_address,
): ):
response = client.post( response = client.post(
url_for('main.sign_in'), data={ url_for('main.sign_in'), data={
'email_address': 'valid@example.gov.uk', 'email_address': email_address,
'password': 'val1dPassw0rd!'}) 'password': 'val1dPassw0rd!'})
assert response.status_code == 302 assert response.status_code == 302
assert response.location == url_for('.two_factor', _external=True) assert response.location == url_for('.two_factor', _external=True)
mock_verify_password.assert_called_with(api_user_active.id, 'val1dPassw0rd!') mock_verify_password.assert_called_with(api_user_active.id, 'val1dPassw0rd!')
mock_get_user_by_email.assert_called_with('valid@example.gov.uk')
def test_process_email_auth_sign_in_return_2fa_template( def test_process_email_auth_sign_in_return_2fa_template(