notify-api-412 use black to enforce python coding style

app/main/views/feedback.py

@@ -20,85 +20,86 @@ from app.utils import hide_from_search_engines
 bank_holidays = BankHolidays(use_cached_holidays=True)
 
 
-@main.route('/support', methods=['GET', 'POST'])
+@main.route("/support", methods=["GET", "POST"])
 @hide_from_search_engines
 def support():
-
     if current_user.is_authenticated:
         form = SupportType()
         if form.validate_on_submit():
-            return redirect(url_for(
-                '.feedback',
-                ticket_type=form.support_type.data,
-            ))
+            return redirect(
+                url_for(
+                    ".feedback",
+                    ticket_type=form.support_type.data,
+                )
+            )
     else:
         form = SupportRedirect()
         if form.validate_on_submit():
-            if form.who.data == 'public':
-                return redirect(url_for(
-                    '.support_public'
-                ))
+            if form.who.data == "public":
+                return redirect(url_for(".support_public"))
             else:
-                return redirect(url_for(
-                    '.feedback',
-                    ticket_type=GENERAL_TICKET_TYPE,
-                ))
+                return redirect(
+                    url_for(
+                        ".feedback",
+                        ticket_type=GENERAL_TICKET_TYPE,
+                    )
+                )
 
-    return render_template('views/support/index.html', form=form)
+    return render_template("views/support/index.html", form=form)
 
 
-@main.route('/support/public')
+@main.route("/support/public")
 @hide_from_search_engines
 def support_public():
-    return render_template('views/support/public.html')
+    return render_template("views/support/public.html")
 
 
-@main.route('/support/triage', methods=['GET', 'POST'])
-@main.route('/support/triage/<ticket_type:ticket_type>', methods=['GET', 'POST'])
+@main.route("/support/triage", methods=["GET", "POST"])
+@main.route("/support/triage/<ticket_type:ticket_type>", methods=["GET", "POST"])
 @hide_from_search_engines
 def triage(ticket_type=PROBLEM_TICKET_TYPE):
     form = Triage()
     if form.validate_on_submit():
-        return redirect(url_for(
-            '.feedback',
-            ticket_type=ticket_type,
-            severe=form.severe.data
-        ))
+        return redirect(
+            url_for(".feedback", ticket_type=ticket_type, severe=form.severe.data)
+        )
     return render_template(
-        'views/support/triage.html',
+        "views/support/triage.html",
         form=form,
         page_title={
-            PROBLEM_TICKET_TYPE: 'Report a problem',
-            GENERAL_TICKET_TYPE: 'Contact Notify.gov support',
-        }.get(ticket_type)
+            PROBLEM_TICKET_TYPE: "Report a problem",
+            GENERAL_TICKET_TYPE: "Contact Notify.gov support",
+        }.get(ticket_type),
     )
 
 
-@main.route('/support/<ticket_type:ticket_type>', methods=['GET', 'POST'])
+@main.route("/support/<ticket_type:ticket_type>", methods=["GET", "POST"])
 @hide_from_search_engines
 def feedback(ticket_type):
     form = FeedbackOrProblem()
 
     if not form.feedback.data:
-        form.feedback.data = session.pop('feedback_message', '')
+        form.feedback.data = session.pop("feedback_message", "")
 
-    if request.args.get('severe') in ['yes', 'no']:
-        severe = convert_to_boolean(request.args.get('severe'))
+    if request.args.get("severe") in ["yes", "no"]:
+        severe = convert_to_boolean(request.args.get("severe"))
     else:
         severe = None
 
-    out_of_hours_emergency = all((
-        ticket_type != QUESTION_TICKET_TYPE,
-        not in_business_hours(),
-        severe,
-    ))
+    out_of_hours_emergency = all(
+        (
+            ticket_type != QUESTION_TICKET_TYPE,
+            not in_business_hours(),
+            severe,
+        )
+    )
 
     if needs_triage(ticket_type, severe):
-        session['feedback_message'] = form.feedback.data
-        return redirect(url_for('.triage', ticket_type=ticket_type))
+        session["feedback_message"] = form.feedback.data
+        return redirect(url_for(".triage", ticket_type=ticket_type))
 
     if needs_escalation(ticket_type, severe):
-        return redirect(url_for('.bat_phone'))
+        return redirect(url_for(".bat_phone"))
 
     if current_user.is_authenticated:
         form.email_address.data = current_user.email_address
@@ -109,12 +110,12 @@ def feedback(ticket_type):
         user_name = form.name.data or None
 
         feedback_msg = render_template(
-            'support-tickets/support-ticket.txt',
+            "support-tickets/support-ticket.txt",
             content=form.feedback.data,
         )
 
         ticket = NotifySupportTicket(
-            subject='Notify feedback',
+            subject="Notify feedback",
             message=feedback_msg,
             ticket_type=get_zendesk_ticket_type(ticket_type),
             p1=out_of_hours_emergency,
@@ -126,54 +127,58 @@ def feedback(ticket_type):
         )
         zendesk_client.send_ticket_to_zendesk(ticket)
 
-        return redirect(url_for(
-            '.thanks',
-            out_of_hours_emergency=out_of_hours_emergency,
-            email_address_provided=(
-                current_user.is_authenticated or bool(form.email_address.data)
-            ),
-        ))
+        return redirect(
+            url_for(
+                ".thanks",
+                out_of_hours_emergency=out_of_hours_emergency,
+                email_address_provided=(
+                    current_user.is_authenticated or bool(form.email_address.data)
+                ),
+            )
+        )
 
     return render_template(
-        'views/support/form.html',
+        "views/support/form.html",
         form=form,
         back_link=(
-            url_for('.support')
-            if severe is None else
-            url_for('.triage', ticket_type=ticket_type)
+            url_for(".support")
+            if severe is None
+            else url_for(".triage", ticket_type=ticket_type)
         ),
         show_status_page_banner=(ticket_type == PROBLEM_TICKET_TYPE),
         page_title={
-            GENERAL_TICKET_TYPE: 'Contact Notify.gov support',
-            PROBLEM_TICKET_TYPE: 'Report a problem',
-            QUESTION_TICKET_TYPE: 'Ask a question or give feedback',
+            GENERAL_TICKET_TYPE: "Contact Notify.gov support",
+            PROBLEM_TICKET_TYPE: "Report a problem",
+            QUESTION_TICKET_TYPE: "Ask a question or give feedback",
         }.get(ticket_type),
     )
 
 
-@main.route('/support/escalate', methods=['GET', 'POST'])
+@main.route("/support/escalate", methods=["GET", "POST"])
 @hide_from_search_engines
 def bat_phone():
-
     if current_user.is_authenticated:
-        return redirect(url_for('main.feedback', ticket_type=PROBLEM_TICKET_TYPE))
+        return redirect(url_for("main.feedback", ticket_type=PROBLEM_TICKET_TYPE))
 
-    return render_template('views/support/bat-phone.html')
+    return render_template("views/support/bat-phone.html")
 
 
-@main.route('/support/thanks', methods=['GET', 'POST'])
+@main.route("/support/thanks", methods=["GET", "POST"])
 @hide_from_search_engines
 def thanks():
     return render_template(
-        'views/support/thanks.html',
-        out_of_hours_emergency=convert_to_boolean(request.args.get('out_of_hours_emergency')),
-        email_address_provided=convert_to_boolean(request.args.get('email_address_provided')),
+        "views/support/thanks.html",
+        out_of_hours_emergency=convert_to_boolean(
+            request.args.get("out_of_hours_emergency")
+        ),
+        email_address_provided=convert_to_boolean(
+            request.args.get("email_address_provided")
+        ),
         out_of_hours=not in_business_hours(),
     )
 
 
 def in_business_hours():
-
     now = datetime.utcnow().replace(tzinfo=pytz.utc)
 
     if is_weekend(now) or is_bank_holiday(now):
@@ -183,15 +188,17 @@ def in_business_hours():
 
 
 def london_time_today_as_utc(hour, minute):
-    return pytz.timezone('Europe/London').localize(
-        datetime.now().replace(hour=hour, minute=minute)
-    ).astimezone(pytz.utc)
+    return (
+        pytz.timezone("Europe/London")
+        .localize(datetime.now().replace(hour=hour, minute=minute))
+        .astimezone(pytz.utc)
+    )
 
 
 def is_weekend(time):
-    return time.strftime('%A') in {
-        'Saturday',
-        'Sunday',
+    return time.strftime("%A") in {
+        "Saturday",
+        "Sunday",
     }
 
 
@@ -200,23 +207,25 @@ def is_bank_holiday(time):
 
 
 def needs_triage(ticket_type, severe):
-    return all((
-        ticket_type != QUESTION_TICKET_TYPE,
-        severe is None,
+    return all(
         (
-            not current_user.is_authenticated or current_user.live_services
-        ),
-        not in_business_hours(),
-    ))
+            ticket_type != QUESTION_TICKET_TYPE,
+            severe is None,
+            (not current_user.is_authenticated or current_user.live_services),
+            not in_business_hours(),
+        )
+    )
 
 
 def needs_escalation(ticket_type, severe):
-    return all((
-        ticket_type != QUESTION_TICKET_TYPE,
-        severe,
-        not current_user.is_authenticated,
-        not in_business_hours(),
-    ))
+    return all(
+        (
+            ticket_type != QUESTION_TICKET_TYPE,
+            severe,
+            not current_user.is_authenticated,
+            not in_business_hours(),
+        )
+    )
 
 
 def get_zendesk_ticket_type(ticket_type):