Make sure partials always have a wrapping <div>

The diffDOM Javascript sometimes throws an error if it can’t calculate
a diff between the original content of the page and the updated HTML
delivered via AJAX. The problem seems to be when there’s not one,
consistent top-level element for it to base its calculations on.

This commit:
- makes sure that all AJAX-delivered partials have a wrapping `<div>`
- that this `<div>` has a consistent class name to make it clear why
  it’s there
This commit is contained in:
Chris Hill-Scott
2016-09-01 11:06:52 +01:00
parent 0967706aed
commit 8c8f321a11
6 changed files with 67 additions and 65 deletions

View File

@@ -1,5 +1,5 @@
{% from "components/pill.html" import pill %} {% from "components/pill.html" import pill %}
<div class="bottom-gutter"> <div class="bottom-gutter ajax-block-container">
{{ pill('Status', counts, request.args.get('status', '')) }} {{ pill('Status', counts, request.args.get('status', '')) }}
</div> </div>

View File

@@ -1,12 +1,13 @@
{% from "components/table.html" import list_table, field, right_aligned_field_heading, date_field, row_heading %} {% from "components/table.html" import list_table, field, right_aligned_field_heading, date_field, row_heading %}
{% if job.job_status == 'scheduled' %} <div class="ajax-block-container">
{% if job.job_status == 'scheduled' %}
<p> <p>
Sending will start at {{ job.scheduled_for|format_time }} Sending will start at {{ job.scheduled_for|format_time }}
</p> </p>
{% else %} {% else %}
{% if notifications %} {% if notifications %}
<div class="dashboard-table"> <div class="dashboard-table">
@@ -68,4 +69,5 @@
</div> </div>
{% endif %} {% endif %}
{% endif %} {% endif %}
</div>

View File

@@ -1,4 +1,4 @@
<div> <div class="ajax-block-container">
<p class='heading-small bottom-gutter'> <p class='heading-small bottom-gutter'>
Uploaded by {{ job.created_by.name }} on {{ job.created_at|format_datetime_short }} Uploaded by {{ job.created_by.name }} on {{ job.created_at|format_datetime_short }}
</p> </p>

View File

@@ -1,7 +1,7 @@
{% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading %} {% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading %}
{% from "components/big-number.html" import big_number -%} {% from "components/big-number.html" import big_number -%}
<div class='dashboard-table'> <div class='dashboard-table ajax-block-container'>
{% call(item, row_number) list_table( {% call(item, row_number) list_table(
jobs, jobs,
caption="Recent files uploaded", caption="Recent files uploaded",

View File

@@ -1,7 +1,7 @@
{% from "components/big-number.html" import big_number_with_status %} {% from "components/big-number.html" import big_number_with_status %}
{% from "components/message-count-label.html" import message_count_label %} {% from "components/message-count-label.html" import message_count_label %}
<div class="grid-row"> <div class="grid-row ajax-block-container">
<div class="column-half"> <div class="column-half">
{{ big_number_with_status( {{ big_number_with_status(
statistics['email']['requested'], statistics['email']['requested'],

View File

@@ -1,6 +1,6 @@
{% from "components/big-number.html" import big_number %} {% from "components/big-number.html" import big_number %}
<div class='grid-row'> <div class='grid-row ajax-block-container'>
<div class='column-half'> <div class='column-half'>
<div class="keyline-block"> <div class="keyline-block">
{{ big_number("Unlimited", 'free email allowance', smaller=True) }} {{ big_number("Unlimited", 'free email allowance', smaller=True) }}